Skip to content

COO-1311: Fix incorrect tooltip positioning for silenced alerts #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

COO-1311: Fix incorrect tooltip positioning for silenced alerts #635

wants to merge 1 commit into from

Conversation

@falox
Copy link
Contributor

@falox falox commented Nov 6, 2025

Cherry-pick #634 from main

@falox
fix: remove duplicate silenced status from alert tooltips
b4ed2a8 
The redundant "Silenced: true" line was causing incorrect tooltip positioning
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@falox: This pull request references COO-1311 which is a valid jira issue.

In response to this:

Cherry-pick #634 from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jgbernalp and kyoto November 6, 2025 11:55
@DavidRajnoha
Copy link
Contributor

DavidRajnoha commented Nov 6, 2025

/label qe-approved

@DavidRajnoha
Copy link
Contributor

DavidRajnoha commented Nov 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@falox: This pull request references COO-1311 which is a valid jira issue.

In response to this:

Cherry-pick #634 from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidRajnoha, falox
Once this PR has been reviewed and has the lgtm label, please assign peteryurkovich for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@falox falox closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbernalp jgbernalp Awaiting requested review from jgbernalp

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@DavidRajnoha DavidRajnoha

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@falox @openshift-ci-robot @DavidRajnoha