Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for daemonset #61

Open
asm582 opened this issue Sep 5, 2024 · 4 comments
Open

Add unit test for daemonset #61

asm582 opened this issue Sep 5, 2024 · 4 comments
Assignees
Milestone

Comments

@asm582
Copy link
Contributor

asm582 commented Sep 5, 2024

create unit tests for daemonset that will run on GPU-enabled cluster, and run locally to verify the output

@kannon92
Copy link
Contributor

kannon92 commented Sep 5, 2024

That would not be unit test then. Unit tests should never require specific hardware requirements.

@asm582
Copy link
Contributor Author

asm582 commented Sep 5, 2024

I agree, I think until we can "truly" mock a GPU this could be an approach.

@asm582
Copy link
Contributor Author

asm582 commented Sep 5, 2024

@sairameshv @mamy-CS PR #67 shows a possible path, based on it I think more tests could be added.

@harche
Copy link
Contributor

harche commented Sep 9, 2024

/assign @sairameshv

@asm582 asm582 added this to the v0.1 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants