Replace network-scripts with NetworkManager for bridge configuration

[markmc]

See also

install-scripts/01_install_requirements.sh

Lines 21 to 23 in a6f3f05

	# FIXME: using deprecated network-scripts needed for NM_CONTROLLED=no
	# interfaces on RHEL-8
	sudo yum install -y network-scripts

install-scripts/02_configure_host.sh

Lines 49 to 60 in a6f3f05

	if [ ! -e /etc/sysconfig/network-scripts/ifcfg-provisioning ] ; then
	echo -e "DEVICE=provisioning\nTYPE=Bridge\nONBOOT=yes\nNM_CONTROLLED=no\nBOOTPROTO=static\nIPADDR=172.22.0.1\nNETMASK=255.255.255.0${ZONE}" | sudo dd of=/etc/sysconfig/network-scripts/ifcfg-provisioning
	fi
	sudo ifdown provisioning || true
	sudo ifup provisioning
	# Need to pass the provision interface for bare metal
	if [ "$PRO_IF" ]; then
	echo -e "DEVICE=$PRO_IF\nTYPE=Ethernet\nONBOOT=yes\nNM_CONTROLLED=no\nBRIDGE=provisioning" | sudo dd of=/etc/sysconfig/network-scripts/ifcfg-$PRO_IF
	sudo ifdown $PRO_IF || true
	sudo ifup $PRO_IF
	fi

install-scripts/02_configure_host.sh

Lines 75 to 89 in a6f3f05

	if [ ! -e /etc/sysconfig/network-scripts/ifcfg-baremetal ] ; then
	echo -e "DEVICE=baremetal\nTYPE=Bridge\nONBOOT=yes\nNM_CONTROLLED=no${ZONE}" | sudo dd of=/etc/sysconfig/network-scripts/ifcfg-baremetal
	fi
	sudo ifdown baremetal || true
	sudo ifup baremetal
	# Add the internal interface to it if requests, this may also be the interface providing
	# external access so we need to make sure we maintain dhcp config if its available
	if [ "$INT_IF" ]; then
	echo -e "DEVICE=$INT_IF\nTYPE=Ethernet\nONBOOT=yes\nNM_CONTROLLED=no\nBRIDGE=baremetal" | sudo dd of=/etc/sysconfig/network-scripts/ifcfg-$INT_IF
	if sudo nmap --script broadcast-dhcp-discover -e $INT_IF | grep "IP Offered" ; then
	grep -q BOOTPROTO /etc/sysconfig/network-scripts/ifcfg-baremetal || (echo -e "\nBOOTPROTO=dhcp\n" | sudo tee -a /etc/sysconfig/network-scripts/ifcfg-baremetal)
	fi
	sudo systemctl restart network
	fi

network-scripts is deprecated in RHEL-8 and we should use NetworkManager to do this instead.

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/considerations_in_adopting_rhel_8/networking_considerations-in-adopting-rhel-8

Network scripts are deprecated in Red Hat Enterprise Linux 8 and are no longer provided by default. The basic installation provides a new version of the ifup and ifdown scripts which call NetworkManager through the nmcli tool. In Red Hat Enterprise Linux 8, to run the ifup and the ifdown scripts, NetworkManager must be running

The following suggests we just need to use nmcli con load

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_and_managing_networking/getting-started-with-managing-networking-with-networkmanager_configuring-and-managing-networking#Using-NetworkManager-with-sysconfig-files_getting-started-with-networking-devices-with-NetworkManager

In Red Hat Enterprise Linux 8, if you edit an ifcfg file, NetworkManager is not automatically aware of the change and has to be prompted to notice the change. If you use one of the tools to update NetworkManager profile settings, NetworkManager does not implement those changes until you reconnect using that profile. For example, if configuration files have been changed using an editor, NetworkManager must read the configuration files again.