Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Unused PPL EARLIEST and LATEST aggregations #3253

Closed
currantw opened this issue Jan 17, 2025 · 0 comments · Fixed by #3254
Closed

[CLEANUP] Unused PPL EARLIEST and LATEST aggregations #3253

currantw opened this issue Jan 17, 2025 · 0 comments · Fixed by #3254
Labels
untriaged

Comments

@currantw
Copy link
Contributor

What needs to be cleaned up

While Implementing earliest and latest relative date time functions in Spark (see issue), I discovered that there was unused PPL syntax for earliest, earliest_time, latest, and latest_time aggregations in the ANTLR parser and lexer.

Upon investigation:

  • These commands are not implemented in either OpenSearch Spark or OpenSearch SQL - they are only included in ANTLR files.
  • These commands do not seem to be referenced in any GitHub issues for either OpenSearch Spark or OpenSearch SQL.
  • These commands do not appear to be necessary. The earliest/latest date or time can already be obtained using the existing min/max aggregations.

As a result, I have removed this PPL syntax from OpenSearch Spark (see pull request), and am recommending we also removing it from OpenSearch SQL.

Why is this important?

For consistency in PPL syntax between OpenSearch Spark or OpenSearch SQL.
This was referenced Jan 17, 2025
Merged
Merged
@currantw currantw changed the title [Cleanup] Unused PPL EARLIEST and LATEST aggregations [CLEANUP] Unused PPL EARLIEST and LATEST aggregations Jan 17, 2025
acarbonetto pushed a commit that referenced this issue Jan 20, 2025
@currantw
#3253 Unused PPL EARLIEST and LATEST aggregations (#3254)
af23a39 
* Remove unused `earliest`, `earliest_time`, `latest`, and `latest_time` aggregations from ANTLR.

---------

Signed-off-by: currantw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3253 Unused PPL EARLIEST and LATEST aggregations Bit-Quill/opensearch-project-sql
1 participant
@currantw