Avoid recursion crash under misuse

Swiddis · Swiddis · commit 878b31a500af · 2025-05-23T12:18:12.000-07:00
The "end - start &lt; 1" case shouldn't ever be reached, but we can still code defensively if the case is hit. The result might not be well-defined but it at least won't crash the whole JVM.

Signed-off-by: Simeon Widdis &lt;sawiddis@amazon.com&gt;
diff --git a/core/src/main/java/org/opensearch/sql/analysis/ExpressionAnalyzer.java b/core/src/main/java/org/opensearch/sql/analysis/ExpressionAnalyzer.java
@@ -316,7 +316,7 @@ private Expression visitIn(
    * @return The final `DSL.or` expression.
    */
   private Expression buildOrTree(Expression[] children, int start, int end) {
-    if (end - start == 1) {
+    if (end - start <= 1) {
       return children[start];
     }
     if (end - start == 2) {

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ private Expression visitIn(`
`316`	`316`	* @return The final `DSL.or` expression.
`317`	`317`	`*/`
`318`	`318`	`private Expression buildOrTree(Expression[] children, int start, int end) {`
`319`		`- if (end - start == 1) {`
	`319`	`+ if (end - start <= 1) {`
`320`	`320`	`return children[start];`
`321`	`321`	`}`
`322`	`322`	`if (end - start == 2) {`