Skip to content

Commit 290523a

Browse files
authored
Fix reporting validation for observability (#231) (#233)
* Update reporting validation for observability Signed-off-by: Joshua Li <[email protected]> * update tests Signed-off-by: Joshua Li <[email protected]>
1 parent 4dd52ac commit 290523a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dashboards-reports/server/utils/__tests__/validationHelper.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ const createReportDefinitionNotebookInput: ReportDefinitionSchemaType = {
7676
report_source: REPORT_TYPE.notebook,
7777
description: 'Hi this is your Notebook on demand',
7878
core_params: {
79-
base_url: `/app/observability#/notebooks/${SAMPLE_SAVED_OBJECT_ID}`,
79+
base_url: `/app/observability-dashboards#/notebooks/${SAMPLE_SAVED_OBJECT_ID}`,
8080
window_width: 1300,
8181
window_height: 900,
8282
report_format: FORMAT.pdf,

dashboards-reports/server/utils/validationHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const isValidRelativeUrl = (relativeUrl: string) => {
3737
export const regexDuration = /^(-?)P(?=\d|T\d)(?:(\d+)Y)?(?:(\d+)M)?(?:(\d+)([DW]))?(?:T(?:(\d+)H)?(?:(\d+)M)?(?:(\d+(?:\.\d+)?)S)?)?$/;
3838
export const regexEmailAddress = /\S+@\S+\.\S+/;
3939
export const regexReportName = /^[\w\-\s\(\)\[\]\,\_\-+]+$/;
40-
export const regexRelativeUrl = /^\/(_plugin\/kibana\/|_dashboards\/)?app\/(dashboards|visualize|discover|observability|notebooks-dashboards\?view=output_only)([?&]security_tenant=.+|)#\/(notebooks\/|view\/|edit\/)?[^\/]+$/;
40+
export const regexRelativeUrl = /^\/(_plugin\/kibana\/|_dashboards\/)?app\/(dashboards|visualize|discover|observability-dashboards|notebooks-dashboards\?view=output_only)([?&]security_tenant=.+|)#\/(notebooks\/|view\/|edit\/)?[^\/]+$/;
4141

4242
export const validateReport = async (
4343
client: ILegacyScopedClusterClient,

0 commit comments

Comments
 (0)