Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] Lower number of PR approvers to 1 #73

Closed
dblock opened this issue Sep 2, 2024 · 4 comments
Closed

[PROPOSAL] Lower number of PR approvers to 1 #73

dblock opened this issue Sep 2, 2024 · 4 comments
Assignees
@VachaShah @harshavamsi
Labels
discuss Identifies discussion issues

Comments

@dblock
Copy link
Member

dblock commented Sep 2, 2024

What/Why

What are you proposing?

This repo is a meta non-production repo, we don't need 2 approvers for all PRs.

What problems are you trying to solve?

PRs sit too long, too few maintainers.
@dblock
Copy link
Member Author

dblock commented Sep 2, 2024

@harshavamsi @VachaShah need your +-1 please?

@dblock dblock added discuss Identifies discussion issues and removed untriaged labels Sep 2, 2024
@VachaShah
Copy link
Collaborator

+1

1 similar comment
@harshavamsi
Copy link
Collaborator

+1

@dblock
Copy link
Member Author

dblock commented Sep 3, 2024

I've reduced the number of approvers to 1, thank you!

Screenshot 2024-09-03 at 2 58 06 PM

@dblock dblock closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VachaShah VachaShah

@harshavamsi harshavamsi

Labels
discuss Identifies discussion issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dblock @VachaShah @harshavamsi