Update validator for index.routing.allocation.total_primary_shards_per_node for index update requests.
#17474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… index per node. Added relevant files for unit test and integration test. Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
…MENT replication indices Signed-off-by: Divyansh Pandey <[email protected]>
…mary shards per node settings only for remote store enabled cluster. Added relevant unit and integration tests. Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
Signed-off-by: Divyansh Pandey <[email protected]>
…chFork Merge main to sync changelog updates with local changes.
…et for cluster which is not remote store enabled Signed-off-by: Divyansh Pandey <[email protected]>
…d relevant integration tests Signed-off-by: Divyansh Pandey <[email protected]>
pandeydivyansh1803
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal and
linuxpi
as code owners
pandeydivyansh1803
requested review from
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
shourya035
reviewed
Feb 27, 2025
| } | ||
|
|
||
| // Check if remote store is enabled | ||
| boolean isRemoteStoreEnabled = clusterService.state() |
There was a problem hiding this comment.
Not ideal, but I see why we needed to do this. Since index settings update is an infrequently invoked API, I think we can keep this here.
@sachinpkale I couldn't see a better way to check if remote store is enabled in this code block. Do you see a better way to do this here?
There was a problem hiding this comment.
Do we know how this is handled in MetadataCreateIndexService?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17474 +/- ##
============================================
+ Coverage 72.42% 72.44% +0.02%
- Complexity 65611 65632 +21
============================================
Files 5304 5304
Lines 304743 304756 +13
Branches 44189 44191 +2
============================================
+ Hits 220701 220792 +91
+ Misses 65888 65865 -23
+ Partials 18154 18099 -55 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to update the index.routing.allocation.total_primary_shards_per_node setting for an existing index in a remote store enabled cluster, an error is encountered stating that this setting can only be used with remote store enabled clusters, despite the cluster actually being remote store enabled.
Changes in this PR, updates the validator for update index setting. The change aims to resolve bug identified in #17295
Related Issues
Resolves #17473
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.