Corrected error

Author: mzecc

src/example_fgen_basic/error_v/creation.py

@@ -54,10 +54,14 @@ def create_error(inv: int) -> ErrorV:
     # Initialise the result from the received index
     res = ErrorV.from_instance_index(instance_index)
 
+    # Tell Fortran to finalise the object on the Fortran side
+    # (all data has been copied to Python now)
+    m_error_v_w.finalise_instance(instance_index)
+
     return res
 
 
-def create_errors(invs: NP_ARRAY_OF_INT, n: int) -> tuple[ErrorV, ...]:
+def create_errors(invs: NP_ARRAY_OF_INT) -> tuple[ErrorV, ...]:
     """
     Create a number of errors
 
@@ -76,7 +80,9 @@ def create_errors(invs: NP_ARRAY_OF_INT, n: int) -> tuple[ErrorV, ...]:
         Created errors
     """
     # Get the result, but receiving an instance index rather than the object itself
-    instance_indexes: NP_ARRAY_OF_INT = m_error_v_creation_w.create_errors(invs)
+    instance_indexes: NP_ARRAY_OF_INT = m_error_v_creation_w.create_errors(
+        invs, len(invs)
+    )
 
     # Initialise the result from the received index
     res = tuple(ErrorV.from_instance_index(i) for i in instance_indexes)

src/example_fgen_basic/error_v/error_v.py

@@ -59,10 +59,6 @@ def from_instance_index(cls, instance_index: int) -> ErrorV:
 
         res = cls(code=code, message=message)
 
-        # Tell Fortran to finalise the object on the Fortran side
-        # (all data has been copied to Python now)
-        m_error_v_w.finalise_instance(instance_index)
-
         return res
 
     def build_fortran_instance(self) -> int:

src/example_fgen_basic/error_v/error_v_manager.f90

@@ -78,6 +78,7 @@ subroutine get_available_instance_index(available_instance_index)
 
         ! TODO: switch to returning a Result type with an error set
         ! res = ResultInt(ErrorV(code=1, message="No available instances"))
+        print *, "print"
         error stop 1
 
     end subroutine get_available_instance_index

tests/unit/test_error_v_creation.py

@@ -23,7 +23,6 @@ def test_create_error_even():
     res = create_error(2.0)
 
     assert isinstance(res, ErrorV)
-
     assert res.code != 0
     assert res.code == 1
     assert res.message == "Even number supplied"
@@ -48,12 +47,13 @@ def test_create_error_lots_of_repeated_calls():
 
 
 def test_create_multiple_errors():
-    res = create_errors(np.arange(6), 6)
-
+    res = create_errors(np.arange(6))
     for i, v in enumerate(res):
         if i % 2 == 0:
+            print(v.code, v.message)
             assert v.code == 1
             assert v.message == "Even number supplied"
         else:
+            print(v.code, v.message)
             assert v.code == 0
             assert v.message == ""