Fortitude CI

mzecc · mzecc · commit 53b1910f6a6a · 2025-09-09T18:58:44.000+02:00
diff --git a/src/example_fgen_basic/error_v/creation.f90 b/src/example_fgen_basic/error_v/creation.f90
@@ -6,7 +6,7 @@ module m_error_v_creation
 
     use m_error_v, only: ErrorV, NO_ERROR_CODE
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: create_error, create_errors
diff --git a/src/example_fgen_basic/error_v/creation_wrapper.f90 b/src/example_fgen_basic/error_v/creation_wrapper.f90
@@ -17,7 +17,7 @@ module m_error_v_creation_w
         error_v_manager_set_instance_index_to => set_instance_index_to, &
         error_v_manager_ensure_instance_array_size_is_at_least => ensure_instance_array_size_is_at_least
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: create_error, create_errors
diff --git a/src/example_fgen_basic/error_v/error_v.f90 b/src/example_fgen_basic/error_v/error_v.f90
@@ -9,7 +9,7 @@
 !> indicates no error (i.e. is our equivalent of a null value).
 module m_error_v
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     integer, parameter, public :: NO_ERROR_CODE = 0
diff --git a/src/example_fgen_basic/error_v/error_v_manager.f90 b/src/example_fgen_basic/error_v/error_v_manager.f90
@@ -6,7 +6,7 @@ module m_error_v_manager
 
     use m_error_v, only: ErrorV
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     type(ErrorV), dimension(:), allocatable :: instance_array
@@ -160,19 +160,19 @@ subroutine ensure_instance_array_size_is_at_least(n)
 
         if (.not. allocated(instance_array)) then
 
-            allocate(instance_array(n))
+            allocate (instance_array(n))
 
-            allocate(instance_available(n))
+            allocate (instance_available(n))
             ! Race conditions ?
             instance_available = .true.
 
         else if (size(instance_available) < n) then
 
-            allocate(tmp_instances(n))
+            allocate (tmp_instances(n))
             tmp_instances(1:size(instance_array)) = instance_array
             call move_alloc(tmp_instances, instance_array)
 
-            allocate(tmp_available(n))
+            allocate (tmp_available(n))
             tmp_available(1:size(instance_available)) = instance_available
             tmp_available(size(instance_available) + 1:size(tmp_available)) = .true.
             call move_alloc(tmp_available, instance_available)
diff --git a/src/example_fgen_basic/error_v/error_v_wrapper.f90 b/src/example_fgen_basic/error_v/error_v_wrapper.f90
@@ -14,7 +14,7 @@ module m_error_v_w
         error_v_manager_get_instance => get_instance, &
         error_v_manager_ensure_instance_array_size_is_at_least => ensure_instance_array_size_is_at_least
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: build_instance, finalise_instance, finalise_instances, &
diff --git a/src/example_fgen_basic/error_v/passing.f90 b/src/example_fgen_basic/error_v/passing.f90
@@ -6,7 +6,7 @@ module m_error_v_passing
 
     use m_error_v, only: ErrorV, NO_ERROR_CODE
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: pass_error, pass_errors
diff --git a/src/example_fgen_basic/error_v/passing_wrapper.f90 b/src/example_fgen_basic/error_v/passing_wrapper.f90
@@ -13,12 +13,12 @@ module m_error_v_passing_w
 
     ! The manager module, which makes this all work
     use m_error_v_manager, only: &
-          error_v_manager_get_instance => get_instance
+        error_v_manager_get_instance => get_instance
     !     error_v_manager_get_available_instance_index => get_available_instance_index, &
     !     error_v_manager_set_instance_index_to => set_instance_index_to, &
     !     error_v_manager_ensure_instance_array_size_is_at_least => ensure_instance_array_size_is_at_least
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: pass_error, pass_errors
diff --git a/src/example_fgen_basic/fpyfgen/base_finalisable.f90 b/src/example_fgen_basic/fpyfgen/base_finalisable.f90
@@ -4,7 +4,7 @@
 !> across the Python-Fortran interface.
 module fpyfgen_base_finalisable
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     integer, parameter, public :: INVALID_INSTANCE_INDEX = -1
@@ -38,7 +38,7 @@ subroutine derived_type_finalise(self)
 
             import :: BaseFinalisable
 
-            implicit none (type, external)
+            implicit none(type, external)
 
             class(BaseFinalisable), intent(inout) :: self
 
diff --git a/src/example_fgen_basic/fpyfgen/derived_type_manager_helpers.f90 b/src/example_fgen_basic/fpyfgen/derived_type_manager_helpers.f90
@@ -3,7 +3,7 @@ module fpyfgen_derived_type_manager_helpers
 
     use fpyfgen_base_finalisable, only: BaseFinalisable, invalid_instance_index
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: get_derived_type_free_instance_number, &
diff --git a/src/example_fgen_basic/get_wavelength.f90 b/src/example_fgen_basic/get_wavelength.f90
@@ -7,7 +7,7 @@ module m_get_wavelength
 
     use kind_parameters, only: dp
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     real(kind=dp), parameter, public :: speed_of_light = 2.99792e8_dp
diff --git a/src/example_fgen_basic/get_wavelength_wrapper.f90 b/src/example_fgen_basic/get_wavelength_wrapper.f90
@@ -15,7 +15,7 @@ module m_get_wavelength_w  ! Convention to date: just suffix wrappers with _w
     ! and the original function should have the same name.
     ! ("o_" for original)
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     public :: get_wavelength
diff --git a/src/example_fgen_basic/kind_parameters.f90 b/src/example_fgen_basic/kind_parameters.f90
@@ -2,7 +2,7 @@
 !> See https://fortran-lang.org/learn/best_practices/floating_point/
 module kind_parameters
 
-    implicit none (type, external)
+    implicit none(type, external)
     private
 
     !> Single precision real numbers, 6 digits, range 10⁻³⁷ to 10³⁷-1; 32 bits
diff --git a/src/example_fgen_basic/result/result.f90 b/src/example_fgen_basic/result/result.f90
@@ -6,16 +6,16 @@ module m_result
 
     use m_error_v, only: ErrorV, NO_ERROR_CODE
 
-    implicit none
+    implicit none (type, external)
     private
 
     type, abstract, public :: Result
     !! Result type
     !!
     !! Holds either the result or an error.
 
-       ! class(*), allocatable :: data_v(..)
-       ! MZ: assumed rank can only be dummy argument NOT type/class argument
+        ! class(*), allocatable :: data_v(..)
+        ! MZ: assumed rank can only be dummy argument NOT type/class argument
         ! Data i.e. the result (if no error occurs)
         !
         ! Assumed rank array
@@ -37,15 +37,15 @@ module m_result
         ! procedure, public:: build
         ! TODO: Think about whether build should be on the abstract class
         ! or just on each concrete implementation
-        procedure, public:: is_error
+        procedure, public :: is_error
         procedure, public :: clean_up
 
     end type Result
 
-  !  interface Result
+    !  interface Result
     !! Constructor interface - see build (TODO: figure out cross-ref syntax) for details
     !    module procedure :: constructor
-   ! end interface Result
+    ! end interface Result
 
 contains
 
@@ -55,7 +55,7 @@ subroutine clean_up(self)
         class(Result), intent(inout) :: self
         ! Hopefully can leave without docstring (like Python)
 
-        if (allocated(self % error_v)) deallocate(self%error_v)
+        if (allocated(self % error_v)) deallocate (self % error_v)
 
     end subroutine clean_up
 
diff --git a/src/example_fgen_basic/result/result_int.f90 b/src/example_fgen_basic/result/result_int.f90
@@ -7,7 +7,7 @@ module m_result_int
     use m_error_v, only: ErrorV
     use m_result, only: Result
 
-    implicit none
+    implicit none (type, external)
     private
 
     type, extends(Result), public :: ResultInteger1D
@@ -18,14 +18,14 @@ module m_result_int
         integer, allocatable :: data_v(:)
         !! Data i.e. the result (if no error occurs)
 
-       ! class(ErrorV), allocatable :: error_v
+        ! class(ErrorV), allocatable :: error_v
         !! Error
 
     contains
 
         private
 
-        procedure, public:: build
+        procedure, public :: build
         ! `finalise` and `is_error` come from abstract base class
         final :: finalise
 
@@ -50,7 +50,7 @@ function constructor(data_v, error_v) result(self)
         integer, allocatable, intent(in), optional :: data_v(:)
         !! Data
 
-        call self%build(data_v_in=data_v, error_v_in=error_v)
+        call self % build(data_v_in=data_v, error_v_in=error_v)
 
     end function constructor
 
@@ -67,30 +67,28 @@ subroutine build(self, data_v_in, error_v_in)
         !! Error message
 
         if (present(data_v_in) .and. present(error_v_in)) then
-            error_v_in%message="Both data and error were provided"
-        elseif (present(data_v_in)) then
-            allocate(self % data_v, source=data_v_in)
+            error_v_in % message = "Both data and error were provided"
+        else if (present(data_v_in)) then
+            allocate (self % data_v, source=data_v_in)
             ! No error - no need to call res % build
-        elseif (present(error_v_in)) then
-            allocate(self % error_v, source=error_v_in)
+        else if (present(error_v_in)) then
+            allocate (self % error_v, source=error_v_in)
             ! No error - no need to call res % build
         else
-            error_v_in%message="Neither data nor error were provided"
+            error_v_in % message = "Neither data nor error were provided"
         end if
 
     end subroutine build
 
     subroutine finalise(self)
       !! Finalise instance
 
-      type(ResultInteger1D), intent(inout) :: self
-      ! Hopefully can leave without docstring (like Python)
+        type(ResultInteger1D), intent(inout) :: self
+        ! Hopefully can leave without docstring (like Python)
 
-      if (allocated(self%data_v)) deallocate(self%data_v)
-      if (allocated(self%error_v)) call self%clean_up()
+        if (allocated(self % data_v)) deallocate (self % data_v)
+        if (allocated(self % error_v)) call self % clean_up()
 
     end subroutine finalise
 
-
-
 end module m_result_int
