Skip to content

Commit 4b209dd

Browse files
committed
Clean up and comment
1 parent 4b7856f commit 4b209dd

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,9 @@ jobs:
118118
# when people try to run without installing optional dependencies,
119119
# we should add a CI step that runs the tests without optional dependencies too.
120120
# We don't have that right now, because we're not sure this pain point exists.
121-
uv-dependency-install-flags: "-v --reinstall-package example-fgen-basic -Ccompile-args='-v' --all-extras --group tests"
121+
uv-dependency-install-flags: "-v --reinstall-package example-fgen-basic -Ccompile-args='-v' --all-extras --group tests "
122122
- name: Run tests
123123
run: |
124-
125124
COV_DIR=`uv run --no-sync python -c 'from pathlib import Path; import example_fgen_basic; print(Path(example_fgen_basic.__file__).parent)'`
126125
uv run --no-sync pytest -r a -v tests src --doctest-modules --doctest-report ndiff --cov=${COV_DIR} --cov-report=term-missing --cov-report=xml
127126
uv run --no-sync coverage report
@@ -240,6 +239,11 @@ jobs:
240239
check-build:
241240
strategy:
242241
matrix:
242+
# The tests are also effectively a test of the build (at least the Fortran compilation).
243+
# This test is really just about checking what is packaged
244+
# and that we have all the required pieces.
245+
# Hence, for now, only test on ubuntu
246+
# (little value testing on other OS's because this test is not testing compilation directly).
243247
os: [ "ubuntu-latest" ]
244248
python-version: [ "3.11" ]
245249
runs-on: "${{ matrix.os }}"
@@ -266,7 +270,6 @@ jobs:
266270
cd dist
267271
ls
268272
python3 -m venv venv
269-
# TODO: alter for windows
270273
source venv/bin/activate
271274
pip install example_fgen_basic*
272275
python -c 'from example_fgen_basic.get_wavelength import get_wavelength_plain; print(get_wavelength_plain(23.4))'

0 commit comments

Comments
 (0)