org.openrewrite.gradle.UpgradeDependencyVersion does not support ExactVersion

[sleylandcole-ccc]

What version of OpenRewrite are you using?

I am using

• OpenRewrite BOM v3.22.0
• Maven/Gradle plugin v7.24.0
• rewrite-gradle (via the BOM listed above)

How are you running OpenRewrite?

I am using the Gradle plugin, and my project is a multi module project.

I've recreated the issue in this repo: https://github.com/sleylandcole-ccc/openrewrite-upgrade-dependency-exact-version. There is a recipe module which contains a recipe to upgrade the Jackson Core dependency to 2.20.+.

The consumer project has a dependency on Jackson Core 2.18.5. You can run the recipe against this module: ./gradlew :consumer:rewriteRun

What is the smallest, simplest way to reproduce the problem?

See repo linked above

What did you expect to see?

This behaviour was described in a Slack message from @shanman190 (here).

I expected the version to be set to 2.20.+ as per the recipe

implementation("com.fasterxml.jackson.core:jackson-core:2.20.+")

What did you see instead?

The version was unchanged

implementation("com.fasterxml.jackson.core:jackson-core:2.18.5")

What is the full stack trace of any errors you encountered?

No errors

Are you interested in contributing a fix to OpenRewrite?

Depending on the amount of work, I could potentially contribute a fix. I will need some guidance on what to change as I haven't contributed to OpenRewrite before.

[timtebeek]

Hi! The version pattern you're using isn't valid I think; you're using:

newVersion: "=2.20.+"

Whereas these two would each be valid

newVersion: "=2.20.0" # Exactly that version

Or alternatively

newVersion: "2.20.+" # Any patch version in the 2.20.x range

See also our page on version selectors: https://docs.openrewrite.org/reference/dependency-version-selectors#exact-version

The take away is that that a prefix of = expects and exact version, and it will call out to Maven Central (or similar) to verify it exists before changing a dependency's version.

[sleylandcole-ccc]

Hi Tim!

Thanks for the incredibly quick response. I've just changed the recipe in my repo to:

type: specs.openrewrite.org/v1beta/recipe
name: com.openrewrite.example.UpgradeToDynamicVersion
displayName: Upgrade to dynamic version
description: Upgrade dependency to dynamic version
recipeList:
  - org.openrewrite.gradle.UpgradeDependencyVersion:
      groupId: com.fasterxml.jackson.core
      artifactId: jackson-core
      newVersion: "2.20.+"

And re-run it. This was the result in the build.gradle file:

implementation("com.fasterxml.jackson.core:jackson-core:2.20.1")

That's still not quite what I want. I want the dynamic version of 2.20.+ – is that possible?

[shanman190]

So in the Gradle selector, it doesn't actually check for the artifact to exist and supports some non-version properties already.

The issue here is that when we reach https://github.com/openrewrite/rewrite/blob/main/rewrite-gradle%2Fsrc%2Fmain%2Fjava%2Forg%2Fopenrewrite%2Fgradle%2FDependencyVersionSelector.java#L167 at which point the ExactVersion contains 25.+, but the available version list contains =25.+ and is filtered out by the isValid method there.

I think there's kinda two possibilities:

• Accept the exact version as is
• Always resolve the version

Based on the conversation, the user wanted to have the literal value be used in the Gradle script and I think sometimes that could be a valid use case to do especially since we support using variable replacements already (ie. Put the literal $springCloudVersion / ${springCloudVersion} into the declared dependency).