Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Issues identified in the jgit gitignore setup #3

Closed
Jenson3210 opened this issue Oct 24, 2024 · 2 comments
Closed

2 Issues identified in the jgit gitignore setup #3

Jenson3210 opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Jenson3210
Copy link

Jenson3210 commented Oct 24, 2024

I might be wrong, but I think there are 2 bugs in the eclipse jgit lib.

Before raising them there, I want to see here if we can get up with a fix that we can then contribute later to jgit also if we really consider them to be buggy.

Consider a file .gitignore with following content

/directory/

This would ignore only directory if it is a directory on the same level as this gitignore.
starting slash: must be on current directory
ending slash: must be a directory.

Bugs are explained/showcased in the tests.

As there are no tests available in original lib/here, I don't feel safe adding changes without talking about them first

@Jenson3210 Jenson3210 added the bug Something isn't working label Oct 24, 2024
Jenson3210 added a commit to Jenson3210/jgit that referenced this issue Oct 24, 2024
@Jenson3210 Jenson3210 self-assigned this Oct 24, 2024
@timtebeek timtebeek moved this to Backlog in OpenRewrite Oct 25, 2024
@Jenson3210
Copy link
Author

also raised it here: eclipse-jgit/jgit#105

@Jenson3210
Copy link
Author

Probably we do not have to put support in for this.
A local written TreeWalk test case is working as expected, so probably it should not allways use IgnoreNode.

In my consuming recipe i moved away from IgnoreNode and came up with a setup using FastIgnoreRules which can be used.

Closing this as I do not really require this usecase anymore

@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant