From e4f549eebd5acca6babacbf38d7f4143c0741458 Mon Sep 17 00:00:00 2001 From: Kai Schlamp Date: Wed, 20 Mar 2024 00:44:59 +0000 Subject: [PATCH] Update TODO --- TODO.md | 4 +--- radis/vespa/utils/document_utils.py | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/TODO.md b/TODO.md index 0b0dd631..895fab4a 100644 --- a/TODO.md +++ b/TODO.md @@ -2,10 +2,8 @@ ## High Priority -- Use own worker for indexing +- Fix pagination of search results - Thinks about a better delete strategy -- Delete document_id from Vespa schema and extract it from the returned id - - - Check if for RAG ranking should be turned off for performance improvements (and using some fixed sort order) - Some present provider.max_results to the user somehow, especially important if the query results (step 1) is larger - task control panel diff --git a/radis/vespa/utils/document_utils.py b/radis/vespa/utils/document_utils.py index 3090a902..0be2cb50 100644 --- a/radis/vespa/utils/document_utils.py +++ b/radis/vespa/utils/document_utils.py @@ -105,6 +105,7 @@ def callback(response: VespaResponse, id: str): def _extract_document_id(documentid: str) -> str: + # https://docs.vespa.ai/en/documents.html#document-ids return documentid.split(":")[-1]