-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UserVoice & Google Analytics Scripts PPRN-Configurable #58
Comments
This ticket replaces #29 and #31 . @pmanko @remomueller do you guys have a google analytics and uservoice endpoint you are pointing myapnea to? I'll factor this out into a config file that will default to a dummy openPPRN endpoint, but can be overridden in a downstream branch. |
We have a uservoice endpoint currently, which we've replaced with our own token, however it's not abstracted out yet: Uses the same view file as the OPN version currently: https://github.com/openpprn/opn/blob/master/app/views/shared/_uservoice_script.html.haml. Same goes for the Google Analytics. These refactored into configuration files would be preferable. (Also with the option to have them as |
I'll implement the solution we have for MyApnea where the uservoice and google analytics tokens are set during initial setup. |
I actually have this complete, but not merged— On Fri, Sep 19, 2014 at 9:10 AM, Piotr Mankowski [email protected]
|
The implemenation I've merged is now using the Figaro gem to specify the keys. See the "Figaro" section of the readme to see how to add your keys. Basic steps are:
your keys will stay private and not checked into github. not like that matters for google and uservoice, but for other stuff. Figaro.env.KEY_NAME can be used to access the key in the app. |
No description provided.
The text was updated successfully, but these errors were encountered: