Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UserVoice & Google Analytics Scripts PPRN-Configurable #58

Closed
seanahrens opened this issue Sep 7, 2014 · 5 comments
Closed

Make UserVoice & Google Analytics Scripts PPRN-Configurable #58

seanahrens opened this issue Sep 7, 2014 · 5 comments
Assignees

Comments

@seanahrens
Copy link
Member

No description provided.

@seanahrens
Copy link
Member Author

This ticket replaces #29 and #31 .

@pmanko @remomueller do you guys have a google analytics and uservoice endpoint you are pointing myapnea to? I'll factor this out into a config file that will default to a dummy openPPRN endpoint, but can be overridden in a downstream branch.

@remomueller
Copy link
Contributor

We have a uservoice endpoint currently, which we've replaced with our own token, however it's not abstracted out yet: Uses the same view file as the OPN version currently: https://github.com/openpprn/opn/blob/master/app/views/shared/_uservoice_script.html.haml. Same goes for the Google Analytics. These refactored into configuration files would be preferable. (Also with the option to have them as nil if the PPRN wants to opt out of these addons).

@pmanko
Copy link
Member

pmanko commented Sep 19, 2014

I'll implement the solution we have for MyApnea where the uservoice and google analytics tokens are set during initial setup.

@seanahrens
Copy link
Member Author

I actually have this complete, but not merged—
Sean Ahrens
seanahrens.org

On Fri, Sep 19, 2014 at 9:10 AM, Piotr Mankowski [email protected]
wrote:

I'll implement the solution we have for MyApnea where the uservoice and google analytics tokens are set during initial setup.

Reply to this email directly or view it on GitHub:
#58 (comment)

@seanahrens
Copy link
Member Author

The implemenation I've merged is now using the Figaro gem to specify the keys. See the "Figaro" section of the readme to see how to add your keys.

Basic steps are:

  1. figaro install
  2. open application.yml and add your keys using the syntax specified on the readme.
  3. i think you're done.

your keys will stay private and not checked into github. not like that matters for google and uservoice, but for other stuff. Figaro.env.KEY_NAME can be used to access the key in the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants