Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trip_stop Event in Trip ID Requirements Documentation #917

Open
hynick4 opened this issue Aug 9, 2024 · 1 comment
Open

Include trip_stop Event in Trip ID Requirements Documentation #917

hynick4 opened this issue Aug 9, 2024 · 1 comment
Labels
minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Milestone

Comments

@hynick4
Copy link

hynick4 commented Aug 9, 2024

Is your feature request related to a problem? Please describe.

The documentation for Passenger Service and Car Share modes both define trip_stop as a valid Event Type, however the event is not listed under Trip ID Requirements as an event that requires a valid trip_id. The trip_stop event is directly related to Trip transitions, so should require a valid trip_id on the event.

Describe the solution you'd like

Add trip_stop as an event that requires a valid trip_id under Trip ID Requirements on Car Share and Passenger Services modes:

Events require a valid `trip_id` in events where `event_types` contains `reservation_start`, `reservation_stop`, `trip_start`, `trip_resume`, `trip_end`,`trip_cancel`, `customer_cancellation`, `provider_cancellation`, or `driver_cancellation`.

Events require a valid `trip_id` in events where `event_types` contains `reservation_start`, `reservation_stop`, `trip_start`, `trip_pause`, `trip_resume`, `trip_end`,`trip_cancel`, `customer_cancellation`, `provider_cancellation`, or `driver_cancellation`.

Is this a breaking change

  • No, not breaking

Impacted Spec

  • provider
@schnuerle schnuerle added this to the 2.1.0 milestone Aug 29, 2024
@schnuerle schnuerle added the minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. label Aug 29, 2024
@schnuerle
Copy link
Member

schnuerle commented Aug 29, 2024

Great thank you and thanks for the catch! We will update in MDS 2.1. If you'd like to be a contributor, you may open a pull request to suggest the details of this change. If not the community can do it at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Projects
None yet
Development

No branches or pull requests

2 participants