Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Functionality documentation #90

Open
mdpiper opened this issue Mar 9, 2021 · 1 comment
Open

JOSS review: Functionality documentation #90

mdpiper opened this issue Mar 9, 2021 · 1 comment

Comments

@mdpiper
Copy link

mdpiper commented Mar 9, 2021

This issue is raised in reference to JOSS submission 3052.

Overall, the documentation is very helpful. However, the scoring measures used, including:

  • Interval Anomaly score
  • Bernoulli Score
  • Best-of-two score
  • Log normal score
  • Poisson score
  • rarity and severity scores
  • critical and unique words for each message

are mentioned in the paper and in the documentation, but they aren't defined in either. Also, how are these scores combined to create the final score? This information should be in either the paper or the documentation.

@ayush-1506
Copy link
Member

Thanks, will add this too. (I didn't want to go deep into the metrics earlier but this seems like something worth adding)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants