Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing requirements and data files in setup.py #5

Open
JanBednarik opened this issue Mar 8, 2018 · 0 comments
Open

Missing requirements and data files in setup.py #5

JanBednarik opened this issue Mar 8, 2018 · 0 comments

Comments

@JanBednarik
Copy link
Contributor

I have updated setup.py so I was able to reserve project name in PyPI. But it cannot be installed by pip now. Requirements are in requirements.txt

Requirements should be moved into install_requires in setup.py and dev requirements (like pytest) should be put aside into extras_require.

I think there are also missing data files like templates in distribution. Should be added by MANIFEST.in file or some param (package_data, data_files, ...) in setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant