Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PyRASA - Spectral parameterization in python based on IRASA #7382

Open
editorialbot opened this issue Oct 20, 2024 · 30 comments
Open
Assignees
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 20, 2024

Submitting author: @schmidtfa (Fabian Schmidt)
Repository: https://github.com/schmidtfa/pyrasa
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @csoneson
Reviewers: Pending
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b13e5cbfdf48d797bab112e533ab2274"><img src="https://joss.theoj.org/papers/b13e5cbfdf48d797bab112e533ab2274/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b13e5cbfdf48d797bab112e533ab2274/status.svg)](https://joss.theoj.org/papers/b13e5cbfdf48d797bab112e533ab2274)

Author instructions

Thanks for submitting your paper to JOSS @schmidtfa. Currently, there isn't a JOSS editor assigned to your paper.

@schmidtfa if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Oct 20, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.11 s (969.9 files/s, 287181.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          57           1713           1927           5252
SVG                              2              0              0           3832
Jupyter Notebook                14              0          17140           1264
YAML                             6              9              7            200
reStructuredText                21            231            222            198
Markdown                         4             75              0            166
TOML                             1             20              0            125
TeX                              1              7              0             77
CSS                              1              3              4             26
DOS Batch                        1              8              1             26
HTML                             1              2              4             12
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           110           2072          19312          11187
-------------------------------------------------------------------------------

Commit count by author:

   102	Thomas Hartmann
    75	Schmidt Fabian
    73	Fabi
     8	Fabian Schmidt
     2	b1059770
     2	dependabot[bot]
     2	schmidtfa

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 660

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 2-Clause "Simplified" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Parameterizing neural power spectra into periodic ...
- No DOI given, and none found for title: MNE software for processing MEG and EEG data
- No DOI given, and none found for title: Array programming with NumPy

❌ MISSING DOIs

- 10.21105/joss.01272 may be a valid DOI for title: NeuroDSP: A package for neural digital signal proc...
- 10.37473/dac/10.1101/2021.10.15.464483 may be a valid DOI for title: Separating neural oscillations from aperiodic 1/f ...
- 10.1155/2011/156869 may be a valid DOI for title: FieldTrip: open source software for advanced analy...
- 10.1007/s10548-015-0448-0 may be a valid DOI for title: Separating fractal and oscillatory components in t...
- 10.7554/elife.70092 may be a valid DOI for title: An open-source, high-performance tool for automate...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Pycrostates: a Python library to study EEG microstates
Submitting author: @vferat
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @AJQuinn, @vahid-sb, @tuliofalmeida, @anshu-97
Similarity score: 0.7609

NeuroDSP: A package for neural digital signal processing
Submitting author: @voytek
Handling editor: @arokem (Retired)
Reviewers: @TomDLT
Similarity score: 0.7529

Openseize: A digital signal processing package for large EEG datasets in Python
Submitting author: @mscaudill
Handling editor: @samhforbes (Active)
Reviewers: @szorowi1, @AJQuinn
Similarity score: 0.7422

MNE-ICALabel: Automatically annotating ICA components with ICLabel in Python
Submitting author: @adam2392
Handling editor: @emdupre (Active)
Reviewers: @TomDonoghue, @adswa
Similarity score: 0.7401

Systole: A python package for cardiac signal synchrony and analysis
Submitting author: @LegrandNico
Handling editor: @osorensen (Active)
Reviewers: @axel-loewe, @janfreyberg
Similarity score: 0.7400

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@schmidtfa
Copy link

fixed the missing dois. so @editorialbot generate pdf

@schmidtfa
Copy link

Also I think Tom Donoghue would be a great fit for a reviewer as he is maintaining fooof/specparam the most widely used package for spectral parametrization.

@arfon
Copy link
Member

arfon commented Nov 12, 2024

@schmidtfa - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 12, 2024
@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Nov 26, 2024

@schmidtfa Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.

@schmidtfa
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.01272 is OK
- 10.1038/s41593-020-00744-x is OK
- 10.1007/s12021-022-09581-8 is OK
- 10.1016/j.neuroimage.2013.10.027 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1155/2011/156869 is OK
- 10.1007/s10548-015-0448-0 is OK
- 10.7554/eLife.70092 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@schmidtfa
Copy link

@Kevin-Mattheus-Moerman looks like its working now. Thanks for having a look at my submission :)

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @sneakers-the-rat as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@sneakers-the-rat is this submission something you can help with?

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@csoneson
Copy link
Member

@editorialbot assign @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @csoneson is now the editor

@csoneson
Copy link
Member

👋🏻 @schmidtfa - I will handle your submission, and start by finding at least two suitable reviewers.

@csoneson
Copy link
Member

👋🏻 @TomDonoghue, @voytek, @vferat - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?

PyRASA - Spectral parameterization in python based on IRASA
#7382

More information about our checklist-based review process can be found here.
Thanks in advance!

@csoneson csoneson removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 10, 2025
@voytek
Copy link

voytek commented Jan 15, 2025

I'm sorry, I can't. I'm serving on an NIH grants panel that meets in a few weeks and I have quite a few grants to review.

@csoneson
Copy link
Member

👋🏻 @TomDonoghue, @vferat, @tuliofalmeida, @mscaudill - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?

PyRASA - Spectral parameterization in python based on IRASA
#7382

More information about our checklist-based review process can be found here.
Thanks in advance!

@tuliofalmeida
Copy link

Hello! Thank you for inviting me but I have no time in the following weeks.

@mscaudill
Copy link

Hi @csoneson Thank you for the invitation. I don't have the bandwidth at this time but I will in early March. If you don't find reviewers before then, please ping me again.

@mscaudill
Copy link

mscaudill commented Jan 22, 2025 via email

@csoneson
Copy link
Member

Ok, thanks @mscaudill!

@TomDonoghue
Copy link

Unfortunately I do not time to review this submission at this time - best of luck with the submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants