From 4fd3467f408a395d87f36c3fae9c209a823fa220 Mon Sep 17 00:00:00 2001 From: Michal Landsman Date: Tue, 4 Feb 2025 12:46:13 +0100 Subject: [PATCH 1/4] navbar GitHub icon - move svg icon to file to support browser cache. --- static/css/custom1.css | 12 +++++++----- static/images/github.svg | 1 + themes/hugo-elate-theme/layouts/partials/nav.html | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) create mode 100644 static/images/github.svg diff --git a/static/css/custom1.css b/static/css/custom1.css index 8190af7..1187724 100644 --- a/static/css/custom1.css +++ b/static/css/custom1.css @@ -137,26 +137,28 @@ h1#javafx-15-highlights { padding-bottom: 13px; } -.navbar svg { +.navbar__icon { width: 24px; height: 24px; - fill: #ffffff; opacity: 0.5; + + /* to white */ + filter: brightness(0) invert(1); } -.navbar svg:hover { +.navbar__icon:hover { opacity: 1; } @media screen and (max-width: 768px) { - .navbar svg { + .navbar__icon { width: 24px; height: 24px; fill: #000000; opacity: 0.5; } - .navbar svg:hover { + .navbar__icon:hover { fill: #52d3aa; opacity: 1; } diff --git a/static/images/github.svg b/static/images/github.svg new file mode 100644 index 0000000..2334976 --- /dev/null +++ b/static/images/github.svg @@ -0,0 +1 @@ +GitHub diff --git a/themes/hugo-elate-theme/layouts/partials/nav.html b/themes/hugo-elate-theme/layouts/partials/nav.html index 8ad1b6e..0d3a0a6 100644 --- a/themes/hugo-elate-theme/layouts/partials/nav.html +++ b/themes/hugo-elate-theme/layouts/partials/nav.html @@ -50,7 +50,7 @@
  • - GitHub + GitHub
    • From a52932c5bf39f701583b9a724e6f1a8bee4073d0 Mon Sep 17 00:00:00 2001 From: Michal Landsman Date: Tue, 4 Feb 2025 13:01:12 +0100 Subject: [PATCH 2/4] navbar GitHub link - target blank --- themes/hugo-elate-theme/layouts/partials/nav.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/themes/hugo-elate-theme/layouts/partials/nav.html b/themes/hugo-elate-theme/layouts/partials/nav.html index 0d3a0a6..979cbfe 100644 --- a/themes/hugo-elate-theme/layouts/partials/nav.html +++ b/themes/hugo-elate-theme/layouts/partials/nav.html @@ -49,7 +49,7 @@ {{ end }}
  • - + GitHub
    • From b95a030a751e1c6da29491313f4e18c9ea89f270 Mon Sep 17 00:00:00 2001 From: Michal Landsman Date: Tue, 4 Feb 2025 13:04:23 +0100 Subject: [PATCH 3/4] navbar - simplify javascript --- static/js/content.js | 2 ++ themes/hugo-elate-theme/static/js/main.js | 39 +++++++++++++---------- 2 files changed, 24 insertions(+), 17 deletions(-) diff --git a/static/js/content.js b/static/js/content.js index aa5b9ad..b40f971 100644 --- a/static/js/content.js +++ b/static/js/content.js @@ -43,6 +43,8 @@ }); }; + // todo: why is this duplicate with main.js ??? + // Page Nav var clickMenu = function() { $('#navbar a:not([class="external"])').click(function(event){ diff --git a/themes/hugo-elate-theme/static/js/main.js b/themes/hugo-elate-theme/static/js/main.js index 240af21..01d25c0 100644 --- a/themes/hugo-elate-theme/static/js/main.js +++ b/themes/hugo-elate-theme/static/js/main.js @@ -61,28 +61,33 @@ // Page Nav var clickMenu = function() { + document.querySelectorAll('#navbar a').forEach(link => { + if (link.classList.contains('external')) { + return; + } - $('#navbar a:not([class="external"])').click(function(event){ - var section = $(this).data('nav-section'), - navbar = $('#navbar'); - - if ( $('[data-section="' + section + '"]').length ) { - $('html, body').animate({ - scrollTop: $('[data-section="' + section + '"]').offset().top - }, 500); - } + link.addEventListener('click', (event) => { + event.preventDefault(); - if ( navbar.is(':visible')) { - navbar.removeClass('in'); - navbar.attr('aria-expanded', 'false'); - $('.js-fh5co-nav-toggle').removeClass('active'); - } + const section = link.getAttribute('data-nav-section'); + const navbar = $('#navbar'); - event.preventDefault(); - return false; - }); + const dataSection = $('[data-section="' + section + '"]'); + if (dataSection.length) { + $('html, body').animate({ + scrollTop: dataSection.offset().top + }, 500); + } + if (navbar.is(':visible')) { + navbar.removeClass('in'); + navbar.attr('aria-expanded', 'false'); + $('.js-fh5co-nav-toggle').removeClass('active'); + } + return false; + }); + }); }; // Reflect scrolling in navigation From 7ea9dd5084de48bd0bc7709b753c8964170d56c6 Mon Sep 17 00:00:00 2001 From: Michal Landsman Date: Tue, 4 Feb 2025 13:05:17 +0100 Subject: [PATCH 4/4] remove unused functions --- themes/hugo-elate-theme/static/js/main.js | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/themes/hugo-elate-theme/static/js/main.js b/themes/hugo-elate-theme/static/js/main.js index 01d25c0..70c1c12 100644 --- a/themes/hugo-elate-theme/static/js/main.js +++ b/themes/hugo-elate-theme/static/js/main.js @@ -2,20 +2,6 @@ 'use strict'; - - - // iPad and iPod detection - var isiPad = function(){ - return (navigator.platform.indexOf("iPad") != -1); - }; - - var isiPhone = function(){ - return ( - (navigator.platform.indexOf("iPhone") != -1) || - (navigator.platform.indexOf("iPod") != -1) - ); - }; - // Parallax var parallax = function() { $(window).stellar();