Skip to content

Commit 54f6149

Browse files
author
duke
committed
Added webrev for tsan/17
1 parent e6e43fb commit 54f6149

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

tsan/17/00-01/commits.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[{"commit":{"message":"Update to address manc@'s review comments."},"files":[{"filename":".jcheck\/conf"},{"filename":"src\/hotspot\/share\/classfile\/systemDictionary.cpp"},{"filename":"src\/hotspot\/share\/gc\/shenandoah\/shenandoahPhaseTimings.hpp"},{"filename":"src\/hotspot\/share\/gc\/shenandoah\/shenandoahRootProcessor.cpp"},{"filename":"src\/hotspot\/share\/gc\/shenandoah\/shenandoahRootProcessor.hpp"},{"filename":"src\/hotspot\/share\/runtime\/globals.hpp"},{"filename":"src\/hotspot\/share\/runtime\/synchronizer.cpp"}],"sha":"efc1f52df170d89e022ac57cf443c4ba0bce1b59"}]

tsan/17/00-01/comparison.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"files":[{"patch":"@@ -7,1 +7,1 @@\n-error=author,committer,whitespace,executable,symlink\n+error=author,committer,reviewers,merge,issues,executable,symlink,message,hg-tag,whitespace,problemlists\n@@ -18,1 +18,1 @@\n-files=.*\\.java$|.*\\.cpp$|.*\\.hpp$|.*\\.c$|.*\\.h$\n+files=.*\\.cpp|.*\\.hpp|.*\\.c|.*\\.h|.*\\.java|.*\\.cc|.*\\.hh|.*\\.m|.*\\.mm|.*\\.gmk|.*\\.m4|.*\\.ac|Makefile\n","filename":".jcheck\/conf","additions":2,"deletions":2,"binary":false,"changes":4,"status":"modified"},{"patch":"@@ -478,1 +478,1 @@\n- assert(calledholdinglock,\"must hold lock for notify\");\n+ assert(calledholdinglock, \"must hold lock for notify\");\n","filename":"src\/hotspot\/share\/classfile\/systemDictionary.cpp","additions":1,"deletions":1,"binary":false,"changes":2,"status":"modified"},{"patch":"@@ -40,9 +40,0 @@\n- f(CNT_PREFIX ## UniverseRoots, DESC_PREFIX \"Universe Roots\") \\\n- f(CNT_PREFIX ## JNIRoots, DESC_PREFIX \"JNI Handles Roots\") \\\n- f(CNT_PREFIX ## JVMTIWeakRoots, DESC_PREFIX \"JVMTI Weak Roots\") \\\n- f(CNT_PREFIX ## JFRWeakRoots, DESC_PREFIX \"JFR Weak Roots\") \\\n- f(CNT_PREFIX ## TSANWeakRoots, DESC_PREFIX \"TSAN Weak Roots\") \\\n- f(CNT_PREFIX ## JNIWeakRoots, DESC_PREFIX \"JNI Weak Roots\") \\\n- f(CNT_PREFIX ## StringTableRoots, DESC_PREFIX \"String Table Roots\") \\\n- f(CNT_PREFIX ## ResolvedMethodTableRoots, DESC_PREFIX \"Resolved Table Roots\") \\\n- f(CNT_PREFIX ## VMGlobalRoots, DESC_PREFIX \"VM Global Roots\") \\\n","filename":"src\/hotspot\/share\/gc\/shenandoah\/shenandoahPhaseTimings.hpp","additions":0,"deletions":9,"binary":false,"changes":9,"status":"modified"},{"patch":"@@ -38,2 +38,0 @@\n-#include \"services\/management.hpp\"\n-#include \"tsan\/tsanOopMap.hpp\"\n","filename":"src\/hotspot\/share\/gc\/shenandoah\/shenandoahRootProcessor.cpp","additions":0,"deletions":2,"binary":false,"changes":2,"status":"modified"},{"patch":"@@ -37,75 +37,0 @@\n-class ShenandoahSerialRoot {\n-public:\n- typedef void (*OopsDo)(OopClosure*);\n-private:\n- ShenandoahSharedFlag _claimed;\n- const OopsDo _oops_do;\n- const ShenandoahPhaseTimings::Phase _phase;\n- const ShenandoahPhaseTimings::ParPhase _par_phase;\n-\n-public:\n- ShenandoahSerialRoot(OopsDo oops_do,\n- ShenandoahPhaseTimings::Phase phase, ShenandoahPhaseTimings::ParPhase par_phase);\n- void oops_do(OopClosure* cl, uint worker_id);\n-};\n-\n-class ShenandoahSerialRoots {\n-private:\n- ShenandoahSerialRoot _universe_root;\n- ShenandoahSerialRoot _object_synchronizer_root;\n- ShenandoahSerialRoot _management_root;\n- ShenandoahSerialRoot _jvmti_root;\n-public:\n- ShenandoahSerialRoots(ShenandoahPhaseTimings::Phase phase);\n- void oops_do(OopClosure* cl, uint worker_id);\n-};\n-\n-class ShenandoahWeakSerialRoot {\n- typedef void (*WeakOopsDo)(BoolObjectClosure*, OopClosure*);\n-private:\n- ShenandoahSharedFlag _claimed;\n- const WeakOopsDo _weak_oops_do;\n- const ShenandoahPhaseTimings::Phase _phase;\n- const ShenandoahPhaseTimings::ParPhase _par_phase;\n-\n-public:\n- ShenandoahWeakSerialRoot(WeakOopsDo oops_do,\n- ShenandoahPhaseTimings::Phase phase, ShenandoahPhaseTimings::ParPhase par_phase);\n- void weak_oops_do(BoolObjectClosure* is_alive, OopClosure* keep_alive, uint worker_id);\n-};\n-\n-#if INCLUDE_JVMTI\n-class ShenandoahJVMTIWeakRoot : public ShenandoahWeakSerialRoot {\n-public:\n- ShenandoahJVMTIWeakRoot(ShenandoahPhaseTimings::Phase phase);\n-};\n-#endif \/\/ INCLUDE_JVMTI\n-\n-#if INCLUDE_JFR\n-class ShenandoahJFRWeakRoot : public ShenandoahWeakSerialRoot {\n-public:\n- ShenandoahJFRWeakRoot(ShenandoahPhaseTimings::Phase phase);\n-};\n-#endif \/\/ INCLUDE_JFR\n-\n-#if INCLUDE_TSAN\n-class ShenandoahTSANWeakRoot : public ShenandoahWeakSerialRoot {\n-public:\n- ShenandoahTSANWeakRoot(ShenandoahPhaseTimings::Phase phase);\n-};\n-#endif \/\/ INCLUDE_TSAN\n-\n-class ShenandoahSerialWeakRoots {\n-private:\n- JVMTI_ONLY(ShenandoahJVMTIWeakRoot _jvmti_weak_roots;)\n- JFR_ONLY(ShenandoahJFRWeakRoot _jfr_weak_roots;)\n- TSAN_ONLY(ShenandoahTSANWeakRoot _tsan_weak_roots;)\n-public:\n- ShenandoahSerialWeakRoots(ShenandoahPhaseTimings::Phase phase) :\n- JVMTI_ONLY(_jvmti_weak_roots(phase))\n- JFR_ONLY(JVMTI_ONLY(COMMA)_jfr_weak_roots(phase))\n- TSAN_ONLY(JVMTI_ONLY(COMMA)_tsan_weak_roots(phase)) {};\n- void weak_oops_do(BoolObjectClosure* is_alive, OopClosure* keep_alive, uint worker_id);\n- void weak_oops_do(OopClosure* cl, uint worker_id);\n-};\n-\n","filename":"src\/hotspot\/share\/gc\/shenandoah\/shenandoahRootProcessor.hpp","additions":0,"deletions":75,"binary":false,"changes":75,"status":"modified"},{"patch":"@@ -2093,0 +2093,1 @@\n+ \\\n","filename":"src\/hotspot\/share\/runtime\/globals.hpp","additions":1,"deletions":0,"binary":false,"changes":1,"status":"modified"},{"patch":"@@ -665,1 +665,1 @@\n- DTRACE_MONITOR_WAIT_PROBE(monitor, obj(), THREAD, millis);\n+ DTRACE_MONITOR_WAIT_PROBE(monitor, obj(), current, millis);\n","filename":"src\/hotspot\/share\/runtime\/synchronizer.cpp","additions":1,"deletions":1,"binary":false,"changes":2,"status":"modified"}]}

tsan/17/00-01/metadata.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"head":{"repo":{"full_name":"jianglizhou\/tsan","html_url":"https:\/\/github.com\/jianglizhou\/tsan"},"sha":"efc1f52df170d89e022ac57cf443c4ba0bce1b59"},"created_at":"2024-03-11T19:37:56.451757616Z","base":{"repo":{"full_name":"openjdk\/tsan","html_url":"https:\/\/git.openjdk.org\/tsan"},"sha":"b21ad21d25c64c45b2f0c2b91bb8b03ff2ad9f7a"}}

0 commit comments

Comments
 (0)