Skip to content

Commit 8edcde4

Browse files
LinuxPackagingPipeline, WinPackagingPipeline: remove unused normalizeShortcuts() methods
1 parent 1042c60 commit 8edcde4

File tree

2 files changed

+0
-50
lines changed

2 files changed

+0
-50
lines changed

src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackagingPipeline.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
*/
2525
package jdk.jpackage.internal;
2626

27-
import static jdk.jpackage.internal.ApplicationBuilder.normalizeLauncherProperty;
2827
import static jdk.jpackage.internal.ApplicationImageUtils.createLauncherIconResource;
2928

3029
import java.io.IOException;
@@ -37,12 +36,8 @@
3736
import jdk.jpackage.internal.PackagingPipeline.PrimaryTaskID;
3837
import jdk.jpackage.internal.PackagingPipeline.TaskID;
3938
import jdk.jpackage.internal.model.Application;
40-
import jdk.jpackage.internal.model.ApplicationLaunchers;
4139
import jdk.jpackage.internal.model.ApplicationLayout;
4240
import jdk.jpackage.internal.model.Launcher;
43-
import jdk.jpackage.internal.model.LauncherShortcut;
44-
import jdk.jpackage.internal.model.LinuxLauncher;
45-
import jdk.jpackage.internal.model.LinuxLauncherMixin;
4641
import jdk.jpackage.internal.model.LinuxPackage;
4742
import jdk.jpackage.internal.resources.ResourceLocator;
4843

@@ -69,17 +64,6 @@ static PackagingPipeline.Builder build(Optional<LinuxPackage> pkg) {
6964
return builder;
7065
}
7166

72-
static ApplicationLaunchers normalizeShortcuts(ApplicationLaunchers appLaunchers) {
73-
return normalizeLauncherProperty(appLaunchers, launcher -> {
74-
// Return "true" if shortcut is not configured for the launcher.
75-
return launcher.shortcut().isEmpty();
76-
}, (LinuxLauncher launcher) -> {
77-
return launcher.shortcut().flatMap(LauncherShortcut::startupDirectory);
78-
}, (launcher, shortcut) -> {
79-
return LinuxLauncher.create(launcher, new LinuxLauncherMixin.Stub(Optional.of(new LauncherShortcut(shortcut))));
80-
});
81-
}
82-
8367
private static void writeLauncherLib(
8468
AppImageBuildEnv<Application, LinuxApplicationLayout> env) throws IOException {
8569

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinPackagingPipeline.java

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -24,26 +24,19 @@
2424
*/
2525
package jdk.jpackage.internal;
2626

27-
import static jdk.jpackage.internal.ApplicationBuilder.normalizeLauncherProperty;
2827
import static jdk.jpackage.internal.ApplicationImageUtils.createLauncherIconResource;
2928

3029
import java.io.IOException;
3130
import java.io.UncheckedIOException;
32-
import java.util.Optional;
33-
import java.util.function.BiFunction;
34-
import java.util.function.Function;
3531
import jdk.jpackage.internal.PackagingPipeline.AppImageBuildEnv;
3632
import jdk.jpackage.internal.PackagingPipeline.BuildApplicationTaskID;
3733
import jdk.jpackage.internal.PackagingPipeline.CopyAppImageTaskID;
3834
import jdk.jpackage.internal.PackagingPipeline.PrimaryTaskID;
3935
import jdk.jpackage.internal.PackagingPipeline.TaskID;
40-
import jdk.jpackage.internal.model.ApplicationLaunchers;
4136
import jdk.jpackage.internal.model.ApplicationLayout;
42-
import jdk.jpackage.internal.model.LauncherShortcut;
4337
import jdk.jpackage.internal.model.PackagerException;
4438
import jdk.jpackage.internal.model.WinApplication;
4539
import jdk.jpackage.internal.model.WinLauncher;
46-
import jdk.jpackage.internal.model.WinLauncherMixin;
4740

4841
final class WinPackagingPipeline {
4942

@@ -60,33 +53,6 @@ static PackagingPipeline.Builder build() {
6053
.applicationAction(WinPackagingPipeline::rebrandLaunchers).add();
6154
}
6255

63-
static ApplicationLaunchers normalizeShortcuts(ApplicationLaunchers appLaunchers) {
64-
65-
appLaunchers = normalizeShortcuts(appLaunchers, WinLauncher::startMenuShortcut, (launcher, shortcut) -> {
66-
return new WinLauncherMixin.Stub(launcher.isConsole(), shortcut, launcher.desktopShortcut());
67-
});
68-
69-
appLaunchers = normalizeShortcuts(appLaunchers, WinLauncher::desktopShortcut, (launcher, shortcut) -> {
70-
return new WinLauncherMixin.Stub(launcher.isConsole(), launcher.startMenuShortcut(), shortcut);
71-
});
72-
73-
return appLaunchers;
74-
}
75-
76-
private static ApplicationLaunchers normalizeShortcuts(
77-
ApplicationLaunchers appLaunchers,
78-
Function<WinLauncher, Optional<LauncherShortcut>> shortcutGetter,
79-
BiFunction<WinLauncherMixin, Optional<LauncherShortcut>, WinLauncherMixin> shortcutOverrider) {
80-
return normalizeLauncherProperty(appLaunchers, launcher -> {
81-
// Return "true" if shortcut is not configured for the launcher.
82-
return shortcutGetter.apply(launcher).isEmpty();
83-
}, (WinLauncher launcher) -> {
84-
return shortcutGetter.apply(launcher).flatMap(LauncherShortcut::startupDirectory);
85-
}, (launcher, shortcut) -> {
86-
return WinLauncher.create(launcher, shortcutOverrider.apply(launcher, Optional.of(new LauncherShortcut(shortcut))));
87-
});
88-
}
89-
9056
private static void rebrandLaunchers(AppImageBuildEnv<WinApplication, ApplicationLayout> env)
9157
throws IOException, PackagerException {
9258
for (var launcher : env.app().launchers()) {

0 commit comments

Comments
 (0)