Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more specific browser title for each page #3058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 7, 2025

Resolve #3054

  • Refactor how the current url is checked inside app.vue. This reduces the amount of String.indexOf() calls, and it makes implementing this PR easier.
  • Fix a bug where Settings menu item in the sidebar isn't highlighted when viewing the Transformation and Persistence sections.
  • Add a new browserTitle config for pages other than the overview page
  • Hide "Sidebar & Visibility" and "Tags" input for the overview page. This frees up some screen real estate for editing widgets
  • Every page has a custom browser page title:
    • Pages will use its browserTitle || label config
    • Overview page will just use label since it's not used elsewhere
    • For other pages, use the section menu's text, so if/when this gets internationalized, the title will also change
    • Settings -> System Settings will use Settings - <navbar title> - openHAB and so it's also automatically localized as the navbar title gets localized.
    • Settings -> Addon settings will use <navbartitle> - openHAB because the navbar title always starts with "Configure....". Adding "Settings - " in front of it would seem redundant.
    • Things/Items/Widgets/Add-on Store/Pages/Rules/Scripts/Scenes will show [X] - [uid] - openHAB e.g. Things - mqtt:topic:xxx - openHAB

browser_title3

Copy link

relativeci bot commented Feb 7, 2025

#2790 Bundle Size — 10.98MiB (+0.02%).

eb41bdc(current) vs 95844d2 main#2743(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2790
     Baseline
#2743
Regression  Initial JS 1.9MiB(+0.12%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.7% 17.51%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2952 2952
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 7 changes Regression 7 regressions
                 Current
#2790
     Baseline
#2743
Regression  JS 9.2MiB (+100%) undefined
Regression  CSS 867.33KiB (+100%) undefined
Regression  Fonts 526.1KiB (+100%) undefined
Regression  Media 295.6KiB (+100%) undefined
Regression  IMG 140.74KiB (+100%) undefined
Regression  HTML 1.38KiB (+100%) undefined
Regression  Other 871B (+100%) undefined

Bundle analysis reportBranch jimtng:browser-titleProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable HTML title for pages
2 participants