Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /rest/transformations missing for demo app #1714

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Fix /rest/transformations missing for demo app #1714

merged 2 commits into from
Jan 1, 2025

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 requested a review from a team as a code owner January 1, 2025 18:52
@florian-h05 florian-h05 mentioned this pull request Jan 1, 2025
Closed
holgerfriedrich
holgerfriedrich approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wborn
wborn requested changes Jan 1, 2025
View reviewed changes
Copy link
Member

@wborn wborn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be added to the runrequires bundles as well. The runbundles is computed using the resolver using the required bundles.

@florian-h05
Address review
aa63505 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Copy link
Contributor Author

Done @wborn

@wborn wborn merged commit e2702e6 into openhab:main Jan 1, 2025
3 checks passed
@wborn wborn added this to the 5.0 milestone Jan 1, 2025
@florian-h05 florian-h05 deleted the demo-app-missing-rest-transform branch January 1, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

stateDescription metadata page is broken in OH 5.0 demo app
3 participants
@florian-h05 @holgerfriedrich @wborn