Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action View network map shown while it should not #2940

Closed
lsiepel opened this issue Dec 22, 2024 · 2 comments · Fixed by #2950
Closed

Action View network map shown while it should not #2940

lsiepel opened this issue Dec 22, 2024 · 2 comments · Fixed by #2950
Labels
bug Something isn't working main ui Main UI

Comments

@lsiepel
Copy link

lsiepel commented Dec 22, 2024 •
edited
Loading

While developing a Zwave-JS binding, i noticed there is an action shown at the Thing page, while i have not defined any action at all. I suspect this action belongs to the existing zwave binding and is shown based on some kind of binding name /zwave string ?!

image

Ah, yes i think i found it here:

openhab-webui/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue

Line 97 in 0ead7b8

<template v-if="thingActions.length > 0 || thingType?.UID?.startsWith('zwave')">

@lsiepel lsiepel added bug Something isn't working main ui Main UI labels Dec 22, 2024
@lsiepel
Copy link
Author

lsiepel commented Dec 22, 2024 •
edited
Loading

Possible fix is to include the colon character.

thingType?.UID?.startsWith('zwave:')">

florian-h05 added a commit to florian-h05/openhab-webui that referenced this issue Dec 28, 2024
@florian-h05
Thing details: Fix Z-Wave network map shown if not Z-Wave binding but…
b700b06 
… related to Z-Wave

Fixes openhab#2940.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 mentioned this issue Dec 28, 2024
Merged
florian-h05 added a commit that referenced this issue Dec 28, 2024
@florian-h05
Thing details: Fix Z-Wave network map shown if not Z-Wave binding (#2950
ba1772c 
)

Fixes #2940.

Signed-off-by: Florian Hotze <[email protected]>
@lsiepel
Copy link
Author

lsiepel commented Dec 28, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thing details: Fix Z-Wave network map shown if not Z-Wave binding florian-h05/openhab-webui
1 participant
@lsiepel