[aWATTar] move calculation logic into best price classes #17729
Merged
+175
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tl-photography
force-pushed
the
feature/move-calc-logic
branch
4 times, most recently
from
0941f94
to
036e83e
Compare
Signed-off-by: Thomas Leber <[email protected]>
…izing zoneId directly and removing unnecessary setup method Signed-off-by: Thomas Leber <[email protected]>
tl-photography
force-pushed
the
feature/move-calc-logic
branch
from
036e83e
to
9460eb0
Compare
|
Sorry for the late review and thanks for your patience! |
lolodomo
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the calculation logic into the corresponding classes and adds tests.