Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Missing label/description in UI for action inputs #17635

Closed
lolodomo opened this issue Oct 27, 2024 · 9 comments · Fixed by #17794
Closed

[freeboxos] Missing label/description in UI for action inputs #17635

lolodomo opened this issue Oct 27, 2024 · 9 comments · Fixed by #17794
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Oct 27, 2024

Some annotations are probably missing.

image

It is not UI issue as it works well for other bindings.

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Oct 27, 2024
@lolodomo
Copy link
Contributor Author

@lolodomo
Copy link
Contributor Author

@florian-h05 : I have a doubt. How this action without @ActionInput can be supported by UI ?

@florian-h05
Copy link
Contributor

From the linked code above I can see it has a @ActionInput annotation.

@lolodomo
Copy link
Contributor Author

From the linked code above I can see it has a @ActionInput annotation.

Yes, you're right ! So, it is normal that they appear in UI.

What is missing is only label and description parameters.

@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 27, 2024

I am going to extend this issue to all bindings defining action inputs without any label. This is a lot...

@lolodomo
Copy link
Contributor Author

@florian-h05 : maybe you could use the name as label in UI when there is no label provided ?
It could be changed in UI side or in core side in the helper class we created.

@florian-h05
Copy link
Contributor

That’s what I’ve also thought.
I would tend to apply that default in the UI.

@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 27, 2024

I would tend to apply that default in the UI.

Yes, I think it is better.

PS: we have 182 input parameters without label.

@florian-h05
Copy link
Contributor

Applied in the UI: openhab/openhab-webui#2840.
The UI now also displays the output description if provided.

lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Nov 23, 2024
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Nov 23, 2024
lsiepel pushed a commit that referenced this issue Nov 30, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
Fix openhab#17635

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants