Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing actions with @ActionOutput annotation to be checked and fixed if necessary #17636

Closed
23 tasks done
lolodomo opened this issue Oct 27, 2024 · 39 comments
Closed
23 tasks done

Thing actions with @ActionOutput annotation to be checked and fixed if necessary #17636

lolodomo opened this issue Oct 27, 2024 · 39 comments
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Oct 27, 2024 •
edited
Loading

Here is the list of bindings containing thing actions with @ActionOutput.
They all have to be checked and fixed if necessary as discussed in #17504
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Oct 27, 2024
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 28, 2024
@lolodomo
[astro/chromecast/doorbird] Fix @ActionOutput annotations
0e1a95e 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Oct 28, 2024
Merged
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 28, 2024
@lolodomo
[a-d] Fix @ActionOutput annotations
70611b7 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>

Deconz
lsiepel pushed a commit that referenced this issue Oct 28, 2024
@lolodomo
[a-d] Fix @ActionOutput annotations (#17644)
cdf0554 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 28, 2024
@lolodomo
[ecobee/flume] Fix @ActionOutput annotations
256f8da 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Oct 28, 2024
Merged
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 29, 2024
@lolodomo
[m-o] Fix @ActionOutput annotations
1ce9ef2 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Oct 29, 2024
Merged
lsiepel pushed a commit that referenced this issue Oct 29, 2024
@lolodomo
[ecobee/flume] Fix @ActionOutput annotations (#17653)
d866c05 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
lsiepel pushed a commit that referenced this issue Oct 29, 2024
@lolodomo
[m-o] Fix @ActionOutput annotations (#17654)
4181395 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
Laith-Budairi pushed a commit to Laith-Budairi/openhab-addons that referenced this issue Oct 29, 2024
@LaithBudairi
[webexteams] Fix @ActionOutput annotations (openhab#17653)
384486b 
    Related to openhab#17636

    Signed-off-by: Laith Budairi <[email protected]>
Laith-Budairi pushed a commit to Laith-Budairi/openhab-addons that referenced this issue Oct 29, 2024
@LaithBudairi
[webexteams] Fix @ActionOutput annotations (openhab#17653)
4bc8b06 
Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
lsiepel pushed a commit that referenced this issue Oct 29, 2024
@Laith-Budairi @LaithBudairi
[webexteams] Fix @ActionOutput annotations (#17653) (#17656)
862c722 
Related to #17636

Signed-off-by: Laith Budairi <[email protected]>
Co-authored-by: Laith Budairi <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 29, 2024
@lolodomo
[p-s] Fix @ActionOutput annotations
e5d9942 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Oct 29, 2024
Merged
lsiepel pushed a commit that referenced this issue Oct 29, 2024
@lolodomo
[p-s] Fix @ActionOutput annotations (#17664)
d047f56 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 29, 2024
@lolodomo
[t*] Fix @ActionOutput annotations
1b08c98 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Oct 29, 2024
Merged
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Oct 29, 2024
@lolodomo
[u-v] Fix @ActionOutput annotations
383615b 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Oct 29, 2024
Merged
lsiepel pushed a commit that referenced this issue Oct 30, 2024
@lolodomo
[u-v] Fix @ActionOutput annotations (#17670)
eae43f2 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
lsiepel pushed a commit that referenced this issue Oct 30, 2024
@lolodomo
[t*] Fix @ActionOutput annotations (#17666)
89e445f 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
Laith-Budairi pushed a commit to Laith-Budairi/openhab-addons that referenced this issue Oct 30, 2024
@LaithBudairi
[x] Fix @ActionOutput annotations
3817573 
Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
@Laith-Budairi Laith-Budairi mentioned this issue Oct 30, 2024
Merged
lsiepel pushed a commit that referenced this issue Oct 30, 2024
@Laith-Budairi
[x] Fix @ActionOutput annotations (#17673)
e163410 
Related to #17636

Signed-off-by: Laith Budairi <[email protected]>
@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 30, 2024 •
edited
Loading

I will have to check the i18n entries for the 6 bindings using @text for the label of output to be sure that the label is "consistent": pushover, pushsafer, satel, tplinksmarthome, tr064 and velux.

And then will remain the only binding that did unusual things with the output actions: energidataservice from @jlaur ;) @florian-h05 your help will be appreciated, I have no clear idea how to annotate all these actions outputs.

@lolodomo lolodomo assigned lolodomo and unassigned lolodomo Oct 30, 2024
@florian-h05
Copy link
Contributor

And then will remain the only binding that did unusual things with the output actions: energidataservice

I will have to think about that, not so easy.

@florian-h05
Copy link
Contributor

I would suggest to fix the annotation, see #17679 (comment).

KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@lolodomo @KaaNee
[a-d] Fix @ActionOutput annotations (openhab#17644)
1977893 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@lolodomo @KaaNee
[ecobee/flume] Fix @ActionOutput annotations (openhab#17653)
1450d75 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@lolodomo @KaaNee
[m-o] Fix @ActionOutput annotations (openhab#17654)
6b4c3cb 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@Laith-Budairi @LaithBudairi @KaaNee
[webexteams] Fix @ActionOutput annotations (openhab#17653) (openhab#1…
eeca5ae 
…7656)

Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
Co-authored-by: Laith Budairi <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@lolodomo @KaaNee
[p-s] Fix @ActionOutput annotations (openhab#17664)
fd075c7 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@lolodomo @KaaNee
[u-v] Fix @ActionOutput annotations (openhab#17670)
0c8f90a 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@lolodomo @KaaNee
[t*] Fix @ActionOutput annotations (openhab#17666)
ebbe25e 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this issue Nov 8, 2024
@Laith-Budairi @KaaNee
[x] Fix @ActionOutput annotations (openhab#17673)
41e5461 
Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
jlaur pushed a commit that referenced this issue Nov 11, 2024
@lolodomo
[energidataservice] Fix @ActionOutput annotations (#17679)
972351b 
Related to #17636

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo
Copy link
Contributor Author

All bindings have been fixed.

matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[a-d] Fix @ActionOutput annotations (openhab#17644)
8647b0a 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[ecobee/flume] Fix @ActionOutput annotations (openhab#17653)
ab59e6d 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[m-o] Fix @ActionOutput annotations (openhab#17654)
9c1727a 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@Laith-Budairi @LaithBudairi @matchews
[webexteams] Fix @ActionOutput annotations (openhab#17653) (openhab#1…
335225d 
…7656)

Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
Co-authored-by: Laith Budairi <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[p-s] Fix @ActionOutput annotations (openhab#17664)
5a16de8 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[u-v] Fix @ActionOutput annotations (openhab#17670)
a4fd245 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[t*] Fix @ActionOutput annotations (openhab#17666)
feb2783 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@Laith-Budairi @matchews
[x] Fix @ActionOutput annotations (openhab#17673)
2f20dc1 
Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Dec 16, 2024
@lolodomo @matchews
[energidataservice] Fix @ActionOutput annotations (openhab#17679)
4acaf26 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[a-d] Fix @ActionOutput annotations (openhab#17644)
d24333a 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[ecobee/flume] Fix @ActionOutput annotations (openhab#17653)
66e32d7 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[m-o] Fix @ActionOutput annotations (openhab#17654)
8836d21 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@Laith-Budairi @LaithBudairi
[webexteams] Fix @ActionOutput annotations (openhab#17653) (openhab#1…
7074c93 
…7656)

Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
Co-authored-by: Laith Budairi <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[p-s] Fix @ActionOutput annotations (openhab#17664)
1feb51c 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[u-v] Fix @ActionOutput annotations (openhab#17670)
6a8a8bc 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[t*] Fix @ActionOutput annotations (openhab#17666)
6e71e4f 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@Laith-Budairi
[x] Fix @ActionOutput annotations (openhab#17673)
a83c961 
Related to openhab#17636

Signed-off-by: Laith Budairi <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@lolodomo
[energidataservice] Fix @ActionOutput annotations (openhab#17679)
d2cbbee 
Related to openhab#17636

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lolodomo @lsiepel @jlaur @florian-h05