diff --git a/bundles/org.openhab.binding.tacmi/NOTICE b/bundles/org.openhab.binding.tacmi/NOTICE index 5e1b5da36a9da..59b4d27a4ab2f 100644 --- a/bundles/org.openhab.binding.tacmi/NOTICE +++ b/bundles/org.openhab.binding.tacmi/NOTICE @@ -17,4 +17,4 @@ https://github.com/openhab/openhab-addons attoparser * License: Apache 2.0 * Project: https://www.attoparser.org -* Source: https://github.com/attoparser/attoparser \ No newline at end of file +* Source: https://github.com/attoparser/attoparser diff --git a/bundles/org.openhab.binding.tacmi/README.md b/bundles/org.openhab.binding.tacmi/README.md index db4681d1f9b10..65fc7391dc2b2 100644 --- a/bundles/org.openhab.binding.tacmi/README.md +++ b/bundles/org.openhab.binding.tacmi/README.md @@ -262,6 +262,3 @@ A Popup with an option field will be shown showing all possible options, like in Please be also aware that there are field having more 'state' values than options, i.E. a manual output override: It has 'Auto/On', 'Auto/Off', 'Manual/On', 'Manual/Off' as state, but only 'Auto', 'Manual/On' and 'Manual/Off' as updateable option. You only set it to 'Auto' and the extension On/Off is added depending on the system's current state. - - -Finally - It would be great to hear from your projects and ideas / solutions! diff --git a/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/coe/TACmiCoEBridgeHandler.java b/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/coe/TACmiCoEBridgeHandler.java index 9aee2147f0bb9..8880f9c796a06 100644 --- a/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/coe/TACmiCoEBridgeHandler.java +++ b/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/coe/TACmiCoEBridgeHandler.java @@ -156,7 +156,7 @@ private void checkForTimeouts() { @Override public void initialize() { try { - final DatagramSocket coeSocket = new DatagramSocket(coePort); + final DatagramSocket coeSocket = new DatagramSocket(COE_PORT); coeSocket.setBroadcast(true); coeSocket.setSoTimeout(330000); // 300 sec is default resent-time; so we wait 330 secs this.coeSocket = coeSocket; @@ -181,7 +181,7 @@ public void initialize() { } public void sendData(final byte[] pkt, final @Nullable InetAddress cmiAddress) throws IOException { - final DatagramPacket packet = new DatagramPacket(pkt, pkt.length, cmiAddress, coePort); + final DatagramPacket packet = new DatagramPacket(pkt, pkt.length, cmiAddress, COE_PORT); @Nullable DatagramSocket sock = this.coeSocket; if (sock == null) { diff --git a/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/TACmiSchemaHandler.java b/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/TACmiSchemaHandler.java index 3ada4f4ba90b1..3dd09c19f6637 100644 --- a/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/TACmiSchemaHandler.java +++ b/bundles/org.openhab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/TACmiSchemaHandler.java @@ -107,7 +107,7 @@ public void initialize() { return; } this.online = false; - updateStatus(ThingStatus.UNKOWN); + updateStatus(ThingStatus.UNKNOWN); this.authHeader = "Basic " + B64Code.encode(config.username + ":" + config.password, StandardCharsets.ISO_8859_1);