Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reasons against GET on /opengdpr_requests/ (List items)? #40

Open
Citrullin opened this issue Jul 13, 2018 · 3 comments
Open

Reasons against GET on /opengdpr_requests/ (List items)? #40

Citrullin opened this issue Jul 13, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Citrullin
Copy link

Citrullin commented Jul 13, 2018

Hi,
we are currently in pre-decision process and we might use the OpenGDPR specification.
I got one question: Are there reasons for not providing an GET endpoint on /opengdpr_requests/?
Besides the authentication issue. You somehow need to make sure that the request has the right to see the response.
If there no reasons against it, I would add it to the specification and create a PR for it.

@akatz0813
Copy link

I am not particularly opposed, but it would have to be optional. We know of implementations that are using nosql backing stores where scans are either quite slow or not supported.

Nonetheless, even if supported, I would expect it to support paging with cursors and filtering by status. There can be many thousands to even millions of requests for large companies.

@Citrullin
Copy link
Author

Since you also didn't specify the authentication, I also wouldn't think about the actual implementation in the specification.

But I agree that this should be optional. Alone for the backwards compatibility. Yes, I would also specify filtering and paging.

@bhox
Copy link
Contributor

bhox commented Dec 3, 2019

@Citrullin Would love a PR to add the request listing endpoint! 👍 Marking this as enhancement and needs help

@bhox bhox added enhancement New feature or request help wanted Extra attention is needed labels Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants