Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apps models from lib-components #1806

Open
AntoLC opened this issue Nov 8, 2022 · 0 comments
Open

Remove apps models from lib-components #1806

AntoLC opened this issue Nov 8, 2022 · 0 comments

Comments

@AntoLC
Copy link
Contributor

AntoLC commented Nov 8, 2022

Problem

We added the application models in "lib-components" by convenience, because some components use them, they shouldn't (circular dependency) and it is not the place of these models, they should be in their own packages: apps-model

Solution

  • Refactorize the components in lib-component using the apps models to not use them anymore.
  • Then move back the models in their correct place, apps/classroom/models.ts should be in lib-classroom package.

Ex:
UploadManager could have a prop isWithContentType, like that the component will be free of apps model dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant