🐛(backend) fix management command to rename BBB documents

After some IRL tests on preprod, the management commands was not working for
some documents. Fixing the command for these cases.

Author: wilbrdt

src/backend/marsha/bbb/management/commands/rename_classroom_documents.py

@@ -9,7 +9,7 @@
 import boto3
 
 from marsha.bbb.models import ClassroomDocument
-from marsha.core.defaults import AWS_STORAGE_BASE_DIRECTORY
+from marsha.core.defaults import AWS_S3, AWS_STORAGE_BASE_DIRECTORY, READY
 from marsha.core.storage.storage_class import file_storage
 from marsha.core.utils import time_utils
 
@@ -44,7 +44,11 @@ def validate_filename(self, value):
     def handle(self, *args, **options):
         """Execute management command."""
 
-        for document in ClassroomDocument.objects.all():
+        documents = ClassroomDocument.objects.filter(
+            storage_location=AWS_S3, upload_state=READY
+        )
+
+        for document in documents:
             # Get the file stored on Scaleway S3 under `aws/`
             stamp = time_utils.to_timestamp(document.uploaded_on)
             extension = ""

src/backend/marsha/bbb/tests/test_command_rename_classroom_documents.py

@@ -13,6 +13,7 @@
 from marsha.bbb.factories import ClassroomDocumentFactory, ClassroomFactory
 from marsha.bbb.management.commands import rename_classroom_documents
 from marsha.bbb.models import ClassroomDocument
+from marsha.core.defaults import AWS_S3, PENDING, READY, SCW_S3
 from marsha.core.utils import time_utils
 
 
@@ -44,8 +45,9 @@ def test_rename_classroom_documents(self, mock_exists):
                     classroom=ClassroomFactory(),
                     filename=filename_src,
                     uploaded_on=now,
+                    upload_state=READY,
+                    storage_location=AWS_S3,
                 )
-
                 documents.append(document)
 
             # Create mocks for copy_objects with Stubber
@@ -82,6 +84,18 @@ def test_rename_classroom_documents(self, mock_exists):
                 }
                 s3_client_stubber.add_response("copy_object", {}, expected_params)
 
+            # Create some classroom documents that should not be concerned
+            ClassroomDocumentFactory(
+                classroom=ClassroomFactory(),
+                upload_state=READY,
+                storage_location=SCW_S3,
+            )
+            ClassroomDocumentFactory(
+                classroom=ClassroomFactory(),
+                upload_state=PENDING,
+                storage_location=AWS_S3,
+            )
+
             call_command("rename_classroom_documents")
 
             s3_client_stubber.assert_no_pending_responses()