Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMIRNOFF: Using non-integer bond orders in interpolation #8

Open
mattwthompson opened this issue Jun 16, 2021 · 2 comments
Open

SMIRNOFF: Using non-integer bond orders in interpolation #8

mattwthompson opened this issue Jun 16, 2021 · 2 comments
Assignees
Labels

Comments

@mattwthompson
Copy link
Member

The spec describes interpolating force constants between bond orders of integers, i.e. 1 and 2. It might be useful to allow interpolating between bond orders that aren't integers, i.e. having the force constant change with bond order with one slope between 1.0 and 1.5, but a different slope between 1.5 and 2.0. The spec does not disallow this, but if we wanted to use them, it would be useful to explicitly state that non-integer values are allows.

This was brought up at some point in the past few months by the team that was investigating WBOs - @SimonBoothroyd or @pavankum may be able to provide more context, including if this is still of scientific interest.

@pavankum
Copy link
Member

Yeah, parameters with a steep slope due to lack of diverse training data tend to produce unphysical k values when extrapolated below 1, if there is flexibility to include non-integer bond orders that would be great so that we can divide into ranges of super-steep and not-so-steep slopes. Another approach discussed was to use a flat value below 1 and interpolate afterwards, may be these can be named as a different scheme, instead of using the tag linear may be step-linear or something similar that conveys it explicitly.

@davidlmobley
Copy link

This is interesting. Yes, I suggest explicitly allowing this.

@mattwthompson mattwthompson self-assigned this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants