Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match="once", match="all_permutations" not described in spec #64

Open
lilyminium opened this issue Mar 20, 2024 · 2 comments
Open

match="once", match="all_permutations" not described in spec #64

lilyminium opened this issue Mar 20, 2024 · 2 comments

Comments

@lilyminium
Copy link
Contributor

In the virtual sites specification, the behaviour of match is never described in the spec -- only the allowed values. As this affects how many particles are added to the molecule, it's an important aspect of defining vsites in the FF.

The allowed values are also don't fully match the implementation, e.g. it specifies match="once" IF type="TrivalentLonePair" but in the Toolkit match="once" is allowed for DivalentLonePair if outOfPlaneAngle is 0.

@j-wags
Copy link
Member

j-wags commented Mar 21, 2024

The behavior of the 'name' field and the hierarchy rules for when multiple vsites assigned to the same atom(s) coexist vs overwrite is also unspecified. Currently this behavior only exists as an implementation detail. (This could be a separate issue but I think it's closely related enough that it should go in this one)

@davidlmobley
Copy link

I think (?) we discussed this in a meeting and said we should do as Jeff says and just introduce an explanation to the spec. But I'd have to consult our last (?) comittee meeting notes to be sure. I think we just need to make sure the spec explains what is implemented otherwise it (the spec) is not complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants