Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coulomb PME convergence criteria no specified? #50

Open
mrshirts opened this issue Jun 6, 2023 · 2 comments
Open

Coulomb PME convergence criteria no specified? #50

mrshirts opened this issue Jun 6, 2023 · 2 comments
Labels

Comments

@mrshirts
Copy link

mrshirts commented Jun 6, 2023

I don't think PME convergence criteria are specified (gaussaina smoothing, number of grid points, etc). Most codes different in what convergence criteria they use, so one could get relatively different answers without specifying this.

@jchodera
Copy link
Member

jchodera commented Jun 7, 2023

I believe our general philosophy is to define the force field for the convergence limit for (Particle Mesh) Ewald-based methods, and allow some level of tolerance in implementations as long as it does not deviate too much from the intended energies.

However, we don't specify how much deviation is "too much" or what metrics of deviation are to be measured. I think this is an area where we could develop some useful tools in the future.

For now, we could place a limit on the energy deviation stddev for a benchmark set of systems, for example. Or, as you suggest, specify a PME cutoff tolerance.

@mattwthompson
Copy link
Member

SMIRNOFF currently offers no guidance beyond

a method like particle mesh Ewald should be used

In the current implementation .setEwaldErrorTolerance(1.0e-4) is used in the OpenMM export. The reason for this choice is historical and I can't argue for it in favor of other values or possible combinations of settings. These settings are not part of the Amber or GROMACS exports as the Ewald settings are not specified in files provided. The case of LAMMPS is a little different but not the most important one to consider here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants