Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Allow "experimental-auto" idivf #1823

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattwthompson
Copy link
Member

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #1823 (ef6a695) into main (5ffcb58) will decrease coverage by 0.29%.
The diff coverage is 40.00%.

Additional details and impacted files

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me and I saw a presentation from @ntBre this morning using this experimental functionality, so I assume there aren't glaring errors. IIRC, this is the first time that we're introducing an indexed parameter that could be int or string. I'd approve this pending adding tests that ensure setters and getters do sane things, including being set to int/string while being accessed both as parameter.idivf[N] and parameter.idivfN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants