Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify=False as an optional named argument to collection.to_records() #269

Closed
j-wags opened this issue Mar 13, 2024 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@j-wags
Copy link
Member

j-wags commented Mar 13, 2024

When a user has to specify verify=False to construct a PortalClient, they aren't able to run to_records later on, since that makes a new PortalClient with the default (verify=True)

from qcportal import PortalClient

qc_client = PortalClient("https://api.qcarchive.molssi.org:443")
from openff.qcsubmit.results import (
    BasicResultCollection,
    OptimizationResultCollection,
    TorsionDriveResultCollection,
)

# Pull down the torsion drive records from the 'OpenFF Protein Capped 3-mer Backbones v1.0' dataset.
torsion_drive_result_collection = TorsionDriveResultCollection.from_server(
    client=qc_client,
    datasets="OpenFF Protein Capped 3-mer Backbones v1.0",
    spec_name="default",
)
from openff.qcsubmit.results.filters import SMARTSFilter

filtered_collection = torsion_drive_result_collection.filter(SMARTSFilter(smarts_to_include=["C[SH]"]))
filtered_collection
torsion_drive_records = filtered_collection.to_records()

(returns a "you should set verify=False" error)

@j-wags j-wags added the bug Something isn't working label Mar 13, 2024
@j-wags j-wags closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant