Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add support for HMR with virtual sites #1056

Open
IAlibay opened this issue Sep 19, 2024 · 1 comment
Open

[ENH] Add support for HMR with virtual sites #1056

IAlibay opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request openmm

Comments

@IAlibay
Copy link

IAlibay commented Sep 19, 2024

Description

I notice the wording is "not yet":

" rigid water, is not yet supported.",

I also don't seem to see any open issues, so erm.. here's an issue for it 🙃

@mattwthompson mattwthompson added the enhancement New feature or request label Sep 20, 2024
@mattwthompson
Copy link
Member

The discussion on this specific behavior when I first implemented it was in Slack, so it ought to be brought out into the public anyway

This is one of the many cases in which we talk about being super general and flexible and xyz but when the rubber hits the road, we really only care about a finite set of use cases. The headache is at the intersection of virtual sites, HMR, and whether or not water is rigid. It gets much simpler to think about if you skip waters when applying HMR, which are probably already rigid if the use case calls for HMR.

We also have comments from Shirts and Gilson that (presumably on ligands) HMR with virtual sites should generally be okay. I basically buy this, since HMR shouldn't interact directly with the virtual sites.

Even though I know you're only using OPC and don't have virtual sites on ligand/protein/solvent, I want to be methodical in removing this restriction. #1055 should hold us over for a little bit, but after that I want to make sure I can run a ligand (with virtual site parameters and HMR) in OPC water without things blowing up. Tests should also make sure

  • Masses in water are not modified if HMR is applied elsewhere in the system
  • Virtual sites continue to never have any mass
  • Some simple ligand-containing system can actually run a few thousand steps at a 4 (5?) fs timestep

@mattwthompson mattwthompson linked a pull request Sep 23, 2024 that will close this issue
27 tasks
@mattwthompson mattwthompson removed a link to a pull request Sep 23, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request openmm
Projects
None yet
Development

No branches or pull requests

2 participants