You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The discussion on this specific behavior when I first implemented it was in Slack, so it ought to be brought out into the public anyway
This is one of the many cases in which we talk about being super general and flexible and xyz but when the rubber hits the road, we really only care about a finite set of use cases. The headache is at the intersection of virtual sites, HMR, and whether or not water is rigid. It gets much simpler to think about if you skip waters when applying HMR, which are probably already rigid if the use case calls for HMR.
We also have comments from Shirts and Gilson that (presumably on ligands) HMR with virtual sites should generally be okay. I basically buy this, since HMR shouldn't interact directly with the virtual sites.
Even though I know you're only using OPC and don't have virtual sites on ligand/protein/solvent, I want to be methodical in removing this restriction. #1055 should hold us over for a little bit, but after that I want to make sure I can run a ligand (with virtual site parameters and HMR) in OPC water without things blowing up. Tests should also make sure
Masses in water are not modified if HMR is applied elsewhere in the system
Virtual sites continue to never have any mass
Some simple ligand-containing system can actually run a few thousand steps at a 4 (5?) fs timestep
Description
I notice the wording is "not yet":
openff-interchange/openff/interchange/interop/openmm/__init__.py
Line 186 in 57dd53a
I also don't seem to see any open issues, so erm.. here's an issue for it 🙃
The text was updated successfully, but these errors were encountered: