Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "username" and "user name" to "public user id" #9942

Closed
stephanegigandet opened this issue Mar 18, 2024 · 7 comments
Closed

Rename "username" and "user name" to "public user id" #9942

stephanegigandet opened this issue Mar 18, 2024 · 7 comments
Assignees
Labels
✨ Feature Features or enhancements to Open Food Facts server 👥 User management

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Mar 18, 2024

What

  • In the forms for users to sign in, create an accound, and edit parameters, we ask for / display the user id, but the field name is "username" or "user name", which is confusing (some users think they should enter their actual name). It would be clearer to name that field "user id".

Code pointers

Needed:
in po/common/common.pot and po/common/en.po:

  • change all the stringids that contain username / user_name to contain user_id instead
  • change those string values to use "user id" instead of "username" or "user name".
@himanshi-154
Copy link

I will work on this issue!!

@stephanegigandet
Copy link
Contributor Author

@himanshi-154 Please wait for the discussion on Slack, just to make sure everyone agrees it is a good thing.

@himanshi-154
Copy link

Sure @stephanegigandet, I will keep myself updated on the discussion!!

@TheSussex
Copy link
Collaborator

I already worked on a fix for this on Friday after I raised the issue @himanshi-154 , was just waiting for A response and go-ahead from @stephanegigandet so I can make a PR.

@john-gom
Copy link
Contributor

Not sure we should do this now as Keycloak supersedes it

@TheSussex
Copy link
Collaborator

Oh I see, I'll follow the discussion on slack to know the final consensus. Thank you.

@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server 👥 User management labels Mar 18, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@CharlesNepote CharlesNepote changed the title Rename "username" and "user name" to "user id" Rename "username" and "user name" to "public user id" Jul 17, 2024
@CharlesNepote
Copy link
Member

CharlesNepote commented Jul 17, 2024

I have renamed the title of this issue, because I think it's very important to let people understand, during account creation, that the user id is public. Many people ask us to change their username (user id) because they didn't understand that it will be public.

See: Account creation: name and user name meaning + what's public and what's private

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Features or enhancements to Open Food Facts server 👥 User management
Development

No branches or pull requests

6 participants