Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On the fly quality checks issues #8420

Closed
CharlesNepote opened this issue May 15, 2023 · 4 comments
Closed

On the fly quality checks issues #8420

CharlesNepote opened this issue May 15, 2023 · 4 comments
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 on-the-fly quality checks ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented May 15, 2023 •
edited by teolemon
Loading

What

  • There are at issues with online quality checks.
  1. The quality check is wrongly triggered in the Kcal and KJ fields

image

  • KJ should always be < 3800 (per 100 g).
  • Kcal should always be < 900 (per 100 g).
  1. The quality check is triggered for value > 100 even if unit is mg

If the unit is mg, then it should be < 100,000. Same issue for µg, etc.

image

  1. Helper in black is under the image (see previous screenshot).

  2. The quality check should be triggered at page load, even if the user does not enter anything.

To Reproduce

See any page in edition. Eg. https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=8410764010474

Context

Part of
@CharlesNepote CharlesNepote added 🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels May 15, 2023
@benbenben2
Copy link
Collaborator

Related to this, if it could be possible to use the "<" symbol without having the field in red, that would be great as well:
image

stephanegigandet added a commit that referenced this issue May 26, 2023
@stephanegigandet
fix: on the fly nutrition edit checks #8420
99783e0
@stephanegigandet stephanegigandet mentioned this issue May 26, 2023
Merged
stephanegigandet added a commit that referenced this issue May 29, 2023
@stephanegigandet
fix: on the fly nutrition edit checks #8420 (#8464)
a82b5ea 
* fix: on the fly nutrition edit checks #8420

* typo
@openfoodfacts-bot openfoodfacts-bot mentioned this issue May 29, 2023
Merged
MonalikaPatnaik pushed a commit to MonalikaPatnaik/openfoodfacts-server that referenced this issue May 31, 2023
@stephanegigandet @MonalikaPatnaik
fix: on the fly nutrition edit checks openfoodfacts#8420 (openfoodfac…
f9d63fe 
…ts#8464)

* fix: on the fly nutrition edit checks openfoodfacts#8420

* typo
@teolemon teolemon mentioned this issue Jun 2, 2023
Closed
@github-actions
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Aug 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Dec 17, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon mentioned this issue Jul 19, 2024
Open
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
@benbenben2
Copy link
Collaborator

solved by Stephane

@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 on-the-fly quality checks ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
🍊 Open Food Facts Server issues
Archived in project
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CharlesNepote @teolemon @benbenben2