Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer verbiage for Edit Product field (Affects US users) #8285

Open
Tracked by #5689
zanovis opened this issue Apr 4, 2023 · 5 comments
Open
Tracked by #5689

Clearer verbiage for Edit Product field (Affects US users) #8285

zanovis opened this issue Apr 4, 2023 · 5 comments
Labels
⚖️ Quantity ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. 🇺🇸 United States Project to improve support in the United States.

Comments

@zanovis
Copy link

zanovis commented Apr 4, 2023

What

  • This issue is to request a more instructive name for the Quantity field for US products.

Example

The current 'Quantity' field is for the product's total mass (if solid) or volume (if liquid). Quantity intuitively seems like the discrete amount of the products in the package, so if you have candy with 2 pieces, quantity would be '2 pieces'.

In the US, we call this value 'Net Weight' and have 'oz'/'g'/'fl oz'/'mL'.
image
image

Current edit product field name: 'Quantity' (API: product_quantity)
image

Proposed US-based edit product field name: 'Net Weight/Volume' (I understand 'weight' is a misnomer, since products display the value in 'oz' AND 'g', but this would make it match US product labels 1:1)
image

To Reproduce

View a product's edit page

Expected behavior

A US user expects to see field titles that match the product's field names on the label.

Additional context

I believe this change would make users more likely to enter this data and it would also improve the reliability of this data because there would be less confusion about if this is 'serving size' vs 'total mass'.

Number of products impacted

  • All US products

Part of

@zanovis zanovis added the 🐛 bug This is a bug, not a feature request. label Apr 4, 2023
@aleene
Copy link
Contributor

aleene commented Apr 5, 2023

The quantity field does not to seem to be processed and normalised. I could not find a normalised entry in the json.

It shoudl also be possible to add the number of servings in this field as well (some extra parsing).

See also: https://wiki.openfoodfacts.org/Products_quantities

@stephanegigandet
Copy link
Contributor

@aleene The "quantity" field is a text field, it is normalized in the "product_quantity" field (which is either in g or in ml).
e.g. https://world.openfoodfacts.org/api/v3/product/3033490004521?fields=quantity,product_quantity

product_quantity: "500",
quantity: "500 g (4 × 125 g)"

@zanovis We could rename the "Quantity" field in "Quantity (Net weight or volume)". Making the name specific to countries would be difficult to maintain.

@aleene
Copy link
Contributor

aleene commented Apr 6, 2023

@stephanegigandet thanks, not sure why I missed that. Might the field be left out sometimes?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 21, 2023
@github-actions github-actions bot removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Aug 17, 2023
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the Stale label Nov 17, 2023
@teolemon teolemon added ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. and removed Stale labels Nov 24, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚖️ Quantity ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. 🇺🇸 United States Project to improve support in the United States.
Projects
Status: To discuss and validate
Development

No branches or pull requests

5 participants