Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field to see which 'server' the product is on #797

Closed
Tracked by #5555 ...
aleene opened this issue Apr 15, 2017 · 9 comments
Closed
Tracked by #5555 ...

Add a field to see which 'server' the product is on #797

aleene opened this issue Apr 15, 2017 · 9 comments
Assignees
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Fixed ? This issue might have been fixed. We can close them once we verify that they have. 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org 🎯 P1

Comments

@aleene
Copy link
Contributor

aleene commented Apr 15, 2017

What

  • Add "new_server":"off" to the OFF-json. I use it to detect product type.

Part of

@stephanegigandet
Copy link
Contributor

You mean to distinguish between OFF and OBF? Why "new" server?

@aleene
Copy link
Contributor Author

aleene commented Apr 15, 2017

I don't know why it is called new_server, that comes from the opff- and opb-servers jsons.

@stephanegigandet
Copy link
Contributor

new_server is something internal, when a product is moved from OFF to OBF or OPFF or the reverse. It will go away, please don't rely on it.

@stephanegigandet
Copy link
Contributor

It should have been transient and not included in the json or the database, it's a bug.

@aleene
Copy link
Contributor Author

aleene commented Apr 16, 2017

OK.
I am just exploring a way to support the three product types within a single app. I need to store the product type for this. I want to rely on info found in the json, so I was looking for a fild that could help me.

@teolemon
Copy link
Member

Oh you want to try displaying them without having to switch ?

@aleene
Copy link
Contributor Author

aleene commented Apr 16, 2017

Do not know yet. At the moment I support a history, which now contains any product type (and complains that a product doesn not exist). So I need to filter to a specif type. But I could try to support an ALL filter.

@teolemon teolemon added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Apr 18, 2017
@aleene
Copy link
Contributor Author

aleene commented May 2, 2017

Still I would like to see from the json-file, which server (product type) it refers to. Maybe add a tag with the original json-link. As I store the jsons from time to time, I can no longer refer to the original http string. And I do not trust the image links for determining the product type, as there is not always an image.

@VaiTon VaiTon changed the title Improve json consistency between servers Add a field to see which 'server' the product is on Jul 27, 2022
@teolemon teolemon added 🎯 P1 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org labels Jun 14, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon moved this to To Discuss and Validate in 🎨 UXR & Design team Apr 25, 2024
@teolemon teolemon added the Fixed ? This issue might have been fixed. We can close them once we verify that they have. label Oct 18, 2024
@teolemon
Copy link
Member

@stephanegigandet closing

@github-project-automation github-project-automation bot moved this from To do to Done in 🐾 Open Pet Food Facts Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To Discuss & Validate to Done in 🧴 Open Beauty Facts Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in 🛠️ - Server - API Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in 📸 Open Products Facts Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To Discuss and Validate to Done in 🎨 UXR & Design team Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Fixed ? This issue might have been fixed. We can close them once we verify that they have. 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org 🎯 P1
Projects
Archived in project
Archived in project
Archived in project
Archived in project
Archived in project
Status: Done
Development

No branches or pull requests

3 participants