Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kabyle (kab) #667

Open
Tracked by #5528
teolemon opened this issue Jan 24, 2017 · 6 comments
Open
Tracked by #5528

Add support for Kabyle (kab) #667

teolemon opened this issue Jan 24, 2017 · 6 comments
Labels
🌐 i18n Regarding software localization 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies

Comments

@teolemon
Copy link
Member

teolemon commented Jan 24, 2017

What

  • Add support for Kabyle (kab) (as requested by a translator which has started work on it on Launchpad)

Part of

@teolemon teolemon added the 🌐 i18n Regarding software localization label Jan 24, 2017
@hangy hangy added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Feb 12, 2017
@hangy
Copy link
Member

hangy commented Feb 12, 2017

This problem is at least twofold.

  • Update taxonomy to contain languages that don't have a language_code_2 value.
  • Update Product Opener to support different versions of language ISO codes. Right now, only two-letter codes are supported. To do this right, it would probably make sense to treat deu and de as equivalent and redirect to the latter, and only allow the language_code_3 to be used, if there is no language_code_2. The $lc variable and it's friends are used everywhere in Product Opener, often with the assumption that it should always contain two characters.

@hangy
Copy link
Member

hangy commented Nov 21, 2017

@hangy hangy closed this as completed Nov 21, 2017
@hangy
Copy link
Member

hangy commented Nov 24, 2017

I was wrong. The issues I mentioned in February still persist.

Also, there is apparently an inconsistency

if ((not defined $lc) or (($lc !~ /^\w\w(_|-)\w\w$/) and (length($lc) != 2) )) {

if ((defined param('lc')) and (defined $language_codes{param('lc')})) {

The former checks that the $lc is only two chars, but the latter does not.

@hangy hangy reopened this Nov 24, 2017
@teolemon
Copy link
Member Author

This is causing issues for Portuguese i think. We need full standard local support for many languages we now have.

@hangy
Copy link
Member

hangy commented Nov 24, 2017

We need full standard local support for many languages we now have.

Anything missing? 😉

@aleene
Copy link
Contributor

aleene commented Jun 22, 2019

I have been using the language codes used by wikidata, which seem sometimes their own invention and I saw some other issues.

  • the current taxonomies sometimes have a rs-entry for croatia. The correct ISO 693-1(?) code is sr. There is a similar issue for norway and norwegian;
  • off needs to support the three letter language codes. These are supported by wikidata and crowdin;
  • sometimes a language has multiple scripts variants. For instance sr can be written in latin and cyrillic script. Wikidata has encoded this as sr-ec and sr-el. Their default entry for sr can be in either script, although cyrillic seems to preferred. There are other countries with this issue as well: Kazakh and Tatar come to mind;
  • the same language can have country variants. In wikidata I saw those for english (canada, great britain), portuguese (brasil), german (switzerland, austria), kazakh (turkey, kazakhstan, china). However there is not much difference between these variants (low impact).
  • chinese is a special case with two variants (han traditional and han simplified). China, Singapore and Malaysia use simplified. Traditional is used by Hongkong, Macao and Taiwan. In vert few cases Hongkong and Taiwan have there own variant. The default is in wikidata very badly defined, sometimes traditional, sometimes simplified.
  • Wikidata has various other deviations. Belarus in old script for instance. (Can make a list).
  • Interestingly Crowdin has other languages that I have yet to see in the wikidata. So we have to think about priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 i18n Regarding software localization 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
Status: To discuss and validate
Development

No branches or pull requests

3 participants