Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of nutrition data specified for a serving size fail, and set the serving size to "serving" #6473

Closed
stephanegigandet opened this issue Mar 9, 2022 · 0 comments · Fixed by #6474
Closed

Import of nutrition data specified for a serving size fail, and set the serving size to "serving" #6473

stephanegigandet opened this issue Mar 9, 2022 · 0 comments · Fixed by #6474
Labels
🐛 bug This is a bug, not a feature request. Data import portions

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Mar 9, 2022 •
edited
Loading

Describe the bug

There's a broken logic in Import.pm, when nutrition_data_per is set to "serving", then we set "serving_size" to "serving" as well.

Probably the cause of #5441 (and related to #5163 )

To Reproduce

Will add test to reproduce the problem.

Expected behavior

serving_size is not changed
@stephanegigandet stephanegigandet added 🐛 bug This is a bug, not a feature request. Data import labels Mar 9, 2022
stephanegigandet added a commit that referenced this issue Mar 9, 2022
@stephanegigandet
fix incorrect serving size import #6473
df38d7e
@stephanegigandet stephanegigandet mentioned this issue Mar 9, 2022
Merged
stephanegigandet added a commit that referenced this issue Mar 9, 2022
@stephanegigandet
fix incorrect serving size import #6473
0d903cd
stephanegigandet added a commit that referenced this issue Mar 9, 2022
@stephanegigandet
fix incorrect serving size import #6473
6dc87a2
alexgarel pushed a commit that referenced this issue Mar 9, 2022
@stephanegigandet
fix: Import serving size bug (#6474)
ee2ee44 
fixes incorrect serving size import #6473
stephanegigandet added a commit that referenced this issue Mar 11, 2022
@stephanegigandet
fix: Add tests for Carrefour France import, + solve serving_size bug (#…
f255f30 
…6476)

* tests for serving size bug

* fix incorrect serving size import #6473

* fix incorrect serving size import #6473

* fix incorrect serving size import #6473

* put carrefour import code in a module + tests

* export multiple languages in sorted order

* fix issue with random language order, fixes #2973

* fix issue with random language order, fixes #2973

* update tests
@benbenben2 benbenben2 mentioned this issue Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug This is a bug, not a feature request. Data import portions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Import serving size bug openfoodfacts/openfoodfacts-server
2 participants
@teolemon @stephanegigandet