Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mockup of value retrieval UI #3206

Open
Tracked by #5612
, #5525
...
teolemon opened this issue Apr 4, 2020 · 9 comments
Open
Tracked by #5612
, #5525
...

Mockup of value retrieval UI #3206

teolemon opened this issue Apr 4, 2020 · 9 comments
Labels
✏️ Editing Fixable via Userscript This issue can be fixed using the Power User Script. 🎨 Mockup available A mockup has been created for this feature. Please however interact before implementing. product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements

Comments

@teolemon
Copy link
Member

teolemon commented Apr 4, 2020 •
edited
Loading

What

  • Mockup of value retrieval UI

Mockups

image

Part of
@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server ✏️ Editing labels Apr 4, 2020
@CharlesNepote
Copy link
Member

Why this feature, I don't get the point? For product name??

@VaiTon
Copy link
Member

VaiTon commented Apr 4, 2020

I think it's meant to be able to use history to revert some changes done to a product page.
I don't think it would give much advantage and it would require lots of additional queries (I think, @hangy, @stephanegigandet?)

@CharlesNepote
Copy link
Member

I think I can easily make it with Power User Script but I don't catch the point. Isn't it very rare to revert product name?

@hangy
Copy link
Member

hangy commented Apr 4, 2020

I think it's meant to be able to use history to revert some changes done to a product page.
I don't think it would give much advantage and it would require lots of additional queries (I think, @hangy, @stephanegigandet?)

Since the product revisions aren't in the database, but just the file system, it probably wouldn't hurt the db much, but could put some pressure on the fs. In any case, it should probably be queried as hoc, when a user clicks on the history link. Iterating through all revisions to get potential changes for all fields on every page load would be too costly.

@teolemon
Copy link
Member Author

teolemon commented Apr 4, 2020

I had the power user script in mind when I designed this.
It's to revert easily to a previous value in case of vandalism

@hangy hangy added the Fixable via Userscript This issue can be fixed using the Power User Script. label Apr 5, 2020
@CharlesNepote
Copy link
Member

I had the power user script in mind when I designed this.
It's to revert easily to a previous value in case of vandalism

Why waste time for such a rare case? Can we show a clear time gain (any kind of approximate metrics would help)?

@github-actions
Copy link
Contributor

Stale issue message

@github-actions github-actions bot closed this as completed Jul 6, 2020
@teolemon
Copy link
Member Author

It's not a rare case. It's not easy to quantify though.

@teolemon teolemon mentioned this issue Aug 21, 2021
Open
8 tasks
@teolemon teolemon added the product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements label Sep 5, 2021
@teolemon teolemon mentioned this issue Sep 5, 2021
Open
This was referenced Jan 25, 2023
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 3, 2024
@teolemon teolemon added 🎨 Mockup available A mockup has been created for this feature. Please however interact before implementing. and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Apr 1, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon moved this to To Discuss and Validate in 🎨 UXR & Design team Apr 25, 2024
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✏️ Editing Fixable via Userscript This issue can be fixed using the Power User Script. 🎨 Mockup available A mockup has been created for this feature. Please however interact before implementing. product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements
Projects
Server - 🐛 📝 Most annoying bugs for editors
Status: To do
🍊 Open Food Facts Server issues
Status: To discuss and validate
🎨 UXR & Design team
Status: To Discuss and Validate
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hangy @CharlesNepote @teolemon @stephanegigandet @VaiTon