Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green-Score display broken on ru.off.org #11184

Open
teolemon opened this issue Jan 3, 2025 · 2 comments
Open

Green-Score display broken on ru.off.org #11184

teolemon opened this issue Jan 3, 2025 · 2 comments
Labels
🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products Russian

Comments

@teolemon
Copy link
Member

teolemon commented Jan 3, 2025

What

Screenshot

Image
Image

@teolemon teolemon added Russian 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products labels Jan 3, 2025
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Jan 3, 2025
@teolemon
Copy link
Member Author

teolemon commented Jan 3, 2025

@alexgarel
Copy link
Member

@teolemon et works for me ! I cannot reproduce.

stephanegigandet added a commit that referenced this issue Jan 10, 2025
This PR fixes an issue with the new Green-Score on some products in some
countries.

When we still have the old ecoscore_data field, and not the new
environmental_score_data field, we use the older ecoscore_data to
compute attributes and knowledge panels.

However, for attributes, some parts of the code also reference
environmental_score_grade, which we didn't copy. For most countries,
this was overriden by the local scores we have in ecoscore_data. But for
countries like Russia, the bug could be seen:
#11184

More and more products have the new environmental_score_data field, so
the bug is less present, but it can still be seen when loading an older
revision of a product:
https://ru.openfoodfacts.org/%D0%BF%D1%80%D0%BE%D0%B4%D1%83%D0%BA%D1%82/8076800195057/spaghetti-n-5-barilla-norge-as?rev=3517

---------

Co-authored-by: Open Food Facts Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products Russian
Projects
Status: To discuss and validate
Development

No branches or pull requests

2 participants