feat: update product_type #11173
feat: update product_type #11173
Conversation
github-actions
bot
added
🧬 Taxonomies
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11173 +/- ##
==========================================
+ Coverage 49.18% 49.21% +0.03%
==========================================
Files 78 78
Lines 22389 22403 +14
Branches 5371 5375 +4
==========================================
+ Hits 11011 11025 +14
+ Misses 10020 10016 -4
- Partials 1358 1362 +4 ☔ View full report in Codecov by Sentry. |
| $error = change_product_type($product_ref, "petfood"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Thanks @benbenben2 that's great.
That said, I would have first computed "expected_product_type" using "has_tag" and if it's defined then, I would have compared it to $product_ref->{product_type}.
It would allow less repetitions in the code.
Are you willing to refactor ?
There was a problem hiding this comment.
Sure. I applied some changes. Is it what you expected?
There was a problem hiding this comment.
it was more:
my $expected_type;
if (has_tag($product_ref, "categories", "en:open-food-facts")) {
$expected_type = "food";
}
elsif (has_tag($product_ref, "categories", "en:open-pet-food-facts")) {
$expected_type = "petfood";
}
elsif (has_tag($product_ref, "categories", "en:open-products-facts")) {
$expected_type = "product";
}
elsif (has_tag($product_ref, "categories", "en:open-beauty-facts")) {
$expected_type = "beauty";
}
if ($expected_type and ($product_ref->{product_type} ne expected_type)) {
$error = change_product_type($product_ref, expected_type);
}
|
| @@ -3678,6 +3721,11 @@ sub analyze_and_enrich_product_data ($product_ref, $response_ref) { | |||
|
|
|||
| compute_languages($product_ref); # need languages for allergens detection and cleaning ingredients | |||
|
|
|||
| # change the product type of non-food categorized products (issue #11094) | |||
| if (has_tag($product_ref, "categories", "en:incorrect-product-type")) { | |||
| review_product_type($product_ref); | |||
There was a problem hiding this comment.
There's something tricky: change_product_type() updates the product_type field and adds a old_product_type, so that store_product() can then remove the product from the old MongoDB collection.
But that means that store_product() must absolutely be called when the product_type is changed.
What you did works for changes done through the website or API, because we call store_product(). But we don't always call store_product(), there is an exception in scripts/update_all_products.pl : when we reprocess ingredients, scores etc.
So we need to change update_all_products.pl so that we do call store_product() if we have a $product_ref->{old_product_type} value. We can use an user like "update-product-type-bot".
See https://github.com/openfoodfacts/openfoodfacts-server/blob/main/scripts/update_all_products.pl#L1405
What
Automatically change the product type of non-food categorized products
Copy pasted all non-something on top of each categories taxonomies.
Also copy pasted categories from food to other flavors (for example, en: Dry Dog Food is moved from taxonomies/food/categories.txt to taxonomies/petfood/categories.txt
Remark
The following, I could not add, but would be a nice to have:
but also categories from food
I tried to do something with remove_tag function from Tags.pm. It removes element of the categories_tags array, but categories (string) and categories_hierarchy (array) remain. And tags are still visible on the website. As I did not want to do some update of the categories string, I decided not to include that in the present PR.
Related issue(s) and discussion