Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use placeholders for URLs in Translations #10218

Open
teolemon opened this issue May 2, 2024 · 1 comment
Open

Use placeholders for URLs in Translations #10218

teolemon opened this issue May 2, 2024 · 1 comment

Comments

@teolemon
Copy link
Member

teolemon commented May 2, 2024

What

msgctxt "warning_not_complete_obf"
msgid "This product page is not complete. You can help to complete it by editing it and adding more data from the photos we have, or by taking more photos using the app for <a href=\"https://play.google.com/store/apps/details?id=org.openbeautyfacts.scanner&hl=en\">Android</a> or <a href=\"https://apps.apple.com/us/app/open-beauty-facts/id1122926380\">iPhone/iPad</a>. Thank you!"

Use placeholders for URLs in Translations when the package name or the language can change.
Deprecate hardcoded URLs
This is error prone, and we loose opportunities

Part of

@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues May 2, 2024
@teolemon teolemon added the ✨ Feature Features or enhancements to Open Food Facts server label May 7, 2024
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
@teolemon
Copy link
Member Author

teolemon commented Oct 24, 2024

We're loosing donations because of this

<a href="https://world.openfoodfacts.org/donate-to-open-food-facts?utm_source=login-open-food-facts"><img src="https://static.openfoodfacts.org/images/svg/donate-icon.svg" alt="Donate to Open Food Facts" /></a><p><<site_name>> is made by a non-profit association, independent from the industry. It is made for all, by all, and it is funded by all. You can support our work by <a href="https://world.openfoodfacts.org/donate-to-open-food-facts?utm_source=login-open-food-facts">donating to Open Food Facts</a> and also by <a href="https://www.lilo.org/fr/open-food-facts/?utm_source=open-food-facts">using the Lilo search engine</a>.<br/><b>Thank you!</b></p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To discuss and validate
Development

No branches or pull requests

1 participant