Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DLC/DLUO field #472

Open
serpico opened this issue Sep 27, 2024 · 5 comments
Open

New DLC/DLUO field #472

serpico opened this issue Sep 27, 2024 · 5 comments

Comments

@serpico
Copy link

serpico commented Sep 27, 2024

Proposed solution

Should we add an optional field for Date Limite de Consommation/Date Limite d'Utilisation Optimale/Best before/Expiration date ? Sometimes it's one of the factors which affect price whether or not the price is discounted. I must confess I don't know exactly how it could be used , though I have a practical example in mind.

PS: it'd be unique per price, so different from the one in OFF

@serpico
Copy link
Author

serpico commented Oct 3, 2024

@rugk
Copy link

rugk commented Jan 10, 2025

Coming here from a very related discussion (aka Forceu/barcodebuddy#125). Barcodebuddy allows to use OpenFoodFacts data to fill in the Grocy DB (kind of an ERP-management tool for your fridge etc.) by requesting it etc.

Now the missing one big piece is actually the expiration date / best before date (BFD). If that would be inside the OpenFoodFacts data or at least some generic estimate on how it is usually (since the time you buy a product), that would help a lot.


For this here, generally I think having this saved as a time span (aka relative datetime span) based on the current day makes most sense. A product likely is discounted if it's BBD is < 3 days from now on, usually only sold until BBD > -1. So -1 < BBD < 3 is what may be relevant for the price.
Also, it then often has a special discount sticker with it's own barcode/EAN, which may replace the old one (you need to check/scan the correct one at checkout) or one which may apply the discount (not yet seen in the wild AFAIK). This may be relevant to the project and it's just my limited experience in Germany, though.

BBD = best before date (I guess)

@serpico
Copy link
Author

serpico commented Jan 10, 2025

I encountered several of those red/orange stickers recently ( ex https://prices.openfoodfacts.org/products/0101052202757 and 3 or 4 others the same day, in the same shop )

Original barcode was 990530101052202757, truncated it to 0101052202757 but still gave me Invalid barcode in the UI

@raphodn
Copy link
Member

raphodn commented Jan 10, 2025

I encountered several of those red/orange stickers recently

The thing with these orange/temporary products is that they very often have internal barcodes... They are kind of in the middle between traditional OFF products (with a valid barcode & packaging), and raw products (categories without any barcodes, such as almonds or tangerines). I feel like we would need a dedicated system to managed them ? If the barcode starts with a 2 for instance ? 🤔

Though most of the products with a BBD will most likely have a valid barcode, for example yogurts, just that depending on their date of production their BBD will vary... I feel it would rather be the work of a "grocery/fridge" app then a price db app 😅

@raphodn
Copy link
Member

raphodn commented Feb 22, 2025

fyi in the web UI you can now specify the discount type (and there is an "Expires soon" option)

@teolemon teolemon removed the ✨ enhancement New feature or request label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants