Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run integration tests and unit tests in docker. remove sqlite #201

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

raphael0202
Copy link
Contributor

This way, we can test against PostgreSQL database. In the commit, we also:

This way, we can test against PostgreSQL database. In the commit,
we also:

- removed labels_tags__like and origins_tags__like filters. These
  filters triggers an error in PostgreSQL, as we're using a JSONB
  field type, which does not support LIKE queries (this bug was in
  production too, see
  https://openfoodfacts.sentry.io/issues/4911496304/?project=4506270533091328&query=LIKE&referrer=issue-stream&sort=freq&statsPeriod=90d&stream_index=0)
- fixed some integration tests to make it work with PostgreSQL
@raphael0202 raphael0202 requested a review from raphodn February 9, 2024 12:32
@raphael0202 raphael0202 force-pushed the run-tests-in-docker branch 8 times, most recently from 86dc304 to 05d8ad2 Compare February 9, 2024 14:59
Copy link
Member

@raphodn raphodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss finally 🙏 💯

@raphodn raphodn changed the title fix: run integration tests and unit tests in docker ci: run integration tests and unit tests in docker Feb 9, 2024
@raphodn raphodn changed the title ci: run integration tests and unit tests in docker ci: run integration tests and unit tests in docker. remove sqlite Feb 9, 2024
@raphodn raphodn merged commit 645add1 into main Feb 9, 2024
7 checks passed
@raphodn raphodn deleted the run-tests-in-docker branch February 9, 2024 15:36
@raphodn raphodn linked an issue Feb 9, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code improvements (tooling, async...)
2 participants